CartoDB / carto-react-template

CARTO for React. The best way to develop Location Intelligence (LI) Apps usign CARTO platform and React
https://sample-app-react.carto.com
MIT License
39 stars 26 forks source link

Add style guide with destructuring of props and components with context (atomic design) #239

Closed aaranadev closed 3 years ago

shortcut-integration[bot] commented 3 years ago

This pull request has been linked to Clubhouse Story #160563: Add style guide with destructuring of props and components with context (atomic design).

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carto-frontend/cra-template-carto/2jD3DefXnYUXFpq5eTii9Yna5W9o
✅ Preview: https://cra-template-carto-git-feature-ch160563-carto-frontend.vercel.app

alasarr commented 3 years ago

Please, add a title at the PR, it's a public repo and the link to CH is not enough.

alasarr commented 3 years ago

A description is also welcome

aaranadev commented 3 years ago

@alasarr I leaved a note in the task: https://app.clubhouse.io/cartoteam/story/160574/improve-the-css-by-default-including-names-and-theme-file.

I've modified the files and the styles, I can't change the style only in other PR without conflicts

alasarr commented 3 years ago

I've modified the files and the styles, I can't change the style only in other PR without conflicts

Create the style PR from this one. And add a note that this PR needs to be merged before

aaranadev commented 3 years ago

Perfect

alasarr commented 3 years ago

Steps:

  1. Create a PR with only the features of this.
  2. Create another PR with the improvement of styles and explain in the title and description what you're doing
aaranadev commented 3 years ago

I've created several PR from this with minor improvements.

I close this PR