CartoDB / carto-react-template

CARTO for React. The best way to develop Location Intelligence (LI) Apps usign CARTO platform and React
https://sample-app-react.carto.com
MIT License
39 stars 26 forks source link

Lazy loading for views #241

Closed aaranadev closed 3 years ago

shortcut-integration[bot] commented 3 years ago

This pull request has been linked to Clubhouse Story #160567: Lazy loading for views.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carto-frontend/cra-template-carto/5Zfn4EqTpVDRCod8FWnnDsgnX51D
✅ Preview: https://cra-template-carto-git-feature-ch160567-carto-frontend.vercel.app

alasarr commented 3 years ago

@aaranadev you need to apply the same changes to skeleton template

aaranadev commented 3 years ago

@alasarr the changes are in skeleton template 🤔

alasarr commented 3 years ago

The skeleton of cloud native

borja-munoz commented 3 years ago

I think it could be helpful to use the lazy loading approach also in the sample app template. In this template we are showing how to work with CARTO for React and this should be the recommended way of working to minimize the file size and improve performance/user experience.

I'll check if I need to update the docs.

aaranadev commented 3 years ago

So, it's ok, I prefer merge it and then change cloud native skeleton

alasarr commented 3 years ago

So, it's ok, I prefer merge it and then change cloud native skeleton

Ok, but don't forget please

alasarr commented 3 years ago

Add it to changelog.md