Closed aaranadev closed 3 years ago
This pull request has been linked to Clubhouse Story #123846: Layers / Legend component.
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/carto-frontend/cra-template-carto/GHDSYeScUendAPAeNXq6C485mK3c
✅ Preview: https://cra-template-carto-git-feature-ch123846-carto-frontend.vercel.app
This PR is blocked until that https://github.com/CartoDB/carto-react/pull/91 will be merged and a new version will be generated.
I won't add the LegendWidget to the other two templates. I think it is enough to have an example in the sample-app and this feature is not so core to have it in the skeleton templates.
There is a couple of minor bugs:
Changes on sample-app look nice to me (tested with link)... 👍🏻
Yes, it's tested with link
I won't add the LegendWidget to the other two templates. I think it is enough to have an example in the sample-app and this feature is not so core to have it in the skeleton templates.
There is a couple of minor bugs:
- The last interval in the KPI legend is missing the "B" for billions
- The legend title in the Tileset legend says "State analysis" and should say "OSM Buildings"
Ok, It's the same for me. If you prefer only in sample-app. I'll remove it of the other templates
I'll take this one, to remove legends and review Borja's comments, so to land it asap
New LegendWidget is added to all skeletons.