CartoDB / carto-react-template

CARTO for React. The best way to develop Location Intelligence (LI) Apps usign CARTO platform and React
https://sample-app-react.carto.com
MIT License
39 stars 26 forks source link

Clean empty asset folders, yarn-error.log, package.dev.json #305

Closed eamador closed 3 years ago

eamador commented 3 years ago

Includes following stories:

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carto-frontend/cra-template-carto/DPuGmPRpE8qx2tHgT6HnB8yrNFaH
✅ Preview: https://cra-template-carto-git-bug-files-cleanup-carto-frontend.vercel.app

borja-munoz commented 3 years ago

Could you confirm if we need the config_overrides.js file?

Discussing with @VictorVelarde a couple days ago it seemed it was only useful to library/template developers. If that's the case, we should remove this file as well.

Clebal commented 3 years ago

@borja-munoz config-overrides.js is necessary if you want to work with carto-react linked in your project.

VictorVelarde commented 3 years ago

We can land this as it is, as it's 100% clear, and discuss about config-overrides.js in the channel / another PR