CartoDB / carto-react

CARTO for React packages
https://docs.carto.com/react/
MIT License
38 stars 16 forks source link

SelectField: Remove empty space at the beginning #772

Closed vmilan closed 1 year ago

vmilan commented 1 year ago

Description

Shortcut: https://app.shortcut.com/cartoteam/story/343957/qa-ui-export-a-workflow

The empty option was added due to some issues with tab navigation, but is not needed anymore and is causing an unwanted blank space.

Remove the white space at the beginning, that white space looks like something failed to render.

This change also affects MultipleSelectField component.

Current UI

Screenshot 2023-09-13 at 11 21 50

Fix

Screenshot 2023-09-13 at 11 22 11
github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit afa8e83):

https://cartodb-fb-storybook-react-dev--pr772-feature-selectfi-sks7wtnt.web.app

(expires Wed, 20 Sep 2023 11:03:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

github-actions[bot] commented 1 year ago

Pull Request Test Coverage Report for Build 6171489216


Totals Coverage Status
Change from base Build 6159410494: 0.0%
Covered Lines: 2261
Relevant Lines: 2931

💛 - Coveralls