CartoDB / carto-react

CARTO for React packages
https://docs.carto.com/react/
MIT License
38 stars 16 forks source link

TexField component: Add support for readOnly #823

Closed vmilan closed 10 months ago

vmilan commented 10 months ago

Description

Shortcut: https://app.shortcut.com/cartoteam/story/357036/textfield-add-read-only-styles [sc-357036]

In some parts of the application, we need to use read-only inputs instead of disabled ones because disabled inputs would not be sent when the form is submitted.

We need to modify our design system (C4R) to have the option to have the same styles for read-only and disabled fields.

Mui doesn't provide a mechanism, like disabled prop but for readOnly inputs, to pass to the root of the component (you can pass it only to the Input), so we need a custom component to do that.

github-actions[bot] commented 10 months ago

Pull Request Test Coverage Report for Build 7543780524


Totals Coverage Status
Change from base Build 7499714104: 0.02%
Covered Lines: 2617
Relevant Lines: 3454

💛 - Coveralls
github-actions[bot] commented 10 months ago

Visit the preview URL for this PR (updated for commit de8025c):

https://cartodb-fb-storybook-react-dev--pr823-feature-evolve-d-uswyyz8k.web.app

(expires Tue, 23 Jan 2024 15:29:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

shortcut-integration[bot] commented 10 months ago

This pull request has been linked to Shortcut Story #357036: TextField - Add read-only styles.