Closed vmilan closed 9 months ago
This pull request has been linked to Shortcut Story #333187: CORE - Autocomplete.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
packages/react-ui/src/theme/sections/components/forms.js | 0 | 7 | 0.0% | ||
<!-- | Total: | 0 | 7 | 0.0% | --> |
Totals | |
---|---|
Change from base Build 7710981155: | -0.2% |
Covered Lines: | 2613 |
Relevant Lines: | 3453 |
Visit the preview URL for this PR (updated for commit 0ddfc33):
https://cartodb-fb-storybook-react-dev--pr828-feature-autocomp-ekk3ozj3.web.app
(expires Wed, 07 Feb 2024 08:48:55 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c
Approach LGTM @vmilan I played with Storybook and the only thing I found was this (Medium > Error, but I think it's a generic issue)
If the text is too long, it 'jumps' into a 2nd line, and it's not visually appealing to me. Is spec like that?
Approach LGTM @vmilan I played with Storybook and the only thing I found was this (Medium > Error, but I think it's a generic issue)
If the text is too long, it 'jumps' into a 2nd line, and it's not visually appealing to me. Is spec like that?
Good catch, there are no specs for this use case, I'll talk to Jose to find a solution. Thanks!
Fix LGTM, thx for the effort here Vero!
Description
Shortcut: https://app.shortcut.com/cartoteam/story/333187/core-autocomplete [sc-333187]
Styles for the autocomplete component in
carto-theme
and documentation in storybook.Type of change