CartoDB / carto-react

CARTO for React packages
https://docs.carto.com/react/
MIT License
38 stars 16 forks source link

New Legend Widget #837

Closed juandjara closed 7 months ago

juandjara commented 9 months ago

Description

Shortcut: https://app.shortcut.com/cartoteam/write/IkRvYyI6I3V1aWQgIjY1MWFiYTI0LTZlMTAtNDJkYi04YzU5LWQ5ZjFjMzhjNzc3MCI=

Revamped LegendWidgetUI with new design, advanced styling and logic customization.

This PR has a companion PR in documentation repo

Type of change

Acceptance

Please describe how to validate the feature or fix

  1. check new design on storybook
  2. match with figma
  3. use in builder

Basic checklist

github-actions[bot] commented 9 months ago

Pull Request Test Coverage Report for Build 8536679157

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/widgets/legend/LegendLayerTitle.js 9 10 90.0%
packages/react-ui/src/widgets/legend/LegendOpacityControl.js 7 9 77.78%
packages/react-ui/src/widgets/legend/LegendLayer.js 44 47 93.62%
packages/react-ui/src/widgets/legend/LegendWidgetUI.js 8 12 66.67%
packages/react-ui/src/widgets/legend/LegendLayerVariable.js 14 24 58.33%
<!-- Total: 166 186 89.25% -->
Files with Coverage Reduction New Missed Lines %
packages/react-ui/src/theme/sections/components/forms.js 7 27.59%
<!-- Total: 7 -->
Totals Coverage Status
Change from base Build 8389817061: -0.2%
Covered Lines: 2679
Relevant Lines: 3571

💛 - Coveralls
github-actions[bot] commented 9 months ago

Visit the preview URL for this PR (updated for commit 1bd89d4):

https://cartodb-fb-storybook-react-dev--pr837-feature-new-lege-zjj9wlde.web.app

(expires Wed, 10 Apr 2024 09:56:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c