Update Deck GL v9 - Githubissues

CartoDB / carto-react

CARTO for React packages

https://docs.carto.com/react/

MIT License

38 stars 16 forks source link

Update Deck GL v9 #838

Closed padawannn closed 7 months ago

padawannn commented 9 months ago

Update to deck V9
Remove dropping features functionality
Adapt useCartoLayerProps to only return properties necessary to interact with the widget system

github-actions[bot] commented 7 months ago

Pull Request Test Coverage Report for Build 8704831341

Details

56 of 62 (90.32%) changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.9%) to 71.233%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/react-widgets/src/layers/EditableCartoGeoJsonLayer.js	0	1	0.0%
packages/react-widgets/src/models/fqn.js	52	57	91.23%
<!--	Total:	56	62	90.32%	-->

Totals
Change from base Build 8628083789:	2.9%
Covered Lines:	2797
Relevant Lines:	3617

💛 - Coveralls

github-actions[bot] commented 7 months ago

Visit the preview URL for this PR (updated for commit a204929):

https://cartodb-fb-storybook-react-dev--pr838-padawannn-deck-v-wcqd9cyr.web.app

_{(expires Tue, 23 Apr 2024 11:35:50 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c}

aaranadev commented 7 months ago

@padawannn, can you review all workspace dependencies?

I see "@carto/react-api": "^3.0.0-alpha.3", when the last version is "@carto/react-api": "^3.0.0-alpha.5" and the ^ doesn't work in alpha,

padawannn commented 7 months ago

@padawannn, can you review all workspace dependencies?

I see "@carto/react-api": "^3.0.0-alpha.3", when the last version is "@carto/react-api": "^3.0.0-alpha.5" and the ^ doesn't work in alpha,

Done, thx