CartoDB / carto-react

CARTO for React packages
https://docs.carto.com/react/
MIT License
38 stars 16 forks source link

Configurable timeseries y axis #861

Closed juandjara closed 7 months ago

juandjara commented 7 months ago

Description

Shortcut: https://app.shortcut.com/cartoteam/story/401311/ui-pdf-report-in-the-pdf-downloaded-the-time-series-widget-should-be-displayed-with-a-y-axis-with-a-scale-of-the-values

This PR depends on PR #860 (that PR should be merged before this one)

This is a PR with a feature required in the design QA phase of the PDF Report in Builder initiative

Type of change

Acceptance

Please describe how to validate the feature or fix

  1. Open C4R Storybook
  2. Go to story for TimeSeriesWidgetUI
  3. Select yAxisType as full
  4. it should look like this

Captura de pantalla 2024-04-09 a las 14 19 39 1

Basic checklist

github-actions[bot] commented 7 months ago

Pull Request Test Coverage Report for Build 8627891374

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/widgets/TimeSeriesWidgetUI/components/TimeSeriesChart.js 5 9 55.56%
<!-- Total: 5 9 55.56% -->
Files with Coverage Reduction New Missed Lines %
packages/react-ui/src/widgets/TimeSeriesWidgetUI/components/TimeSeriesChart.js 1 54.87%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 8627882200: -0.02%
Covered Lines: 2685
Relevant Lines: 3578

💛 - Coveralls
github-actions[bot] commented 7 months ago

Visit the preview URL for this PR (updated for commit 3301cfd):

https://cartodb-fb-storybook-react-dev--pr861-feature-configur-b93jb5ks.web.app

(expires Wed, 17 Apr 2024 08:04:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c