CartoDB / carto-react

CARTO for React packages
https://docs.carto.com/react/
MIT License
38 stars 16 forks source link

TimeSeriesWidget: fix echarts props update, to keep state of control when clicking #865

Closed zbigg closed 7 months ago

zbigg commented 7 months ago

Description

Shortcut: https://app.shortcut.com/cartoteam/story/404593/builder-timeserieswidget-tooltip-disappears-when-clicking-on-series

In TimeseriesWidget, fix way we update props in echarts instance so

(note, data update still resets control animation/filter state)

Fixes regression from #863

Type of change

Acceptance

Please describe how to validate the feature or fix

  1. go to X
  2. test Y
  3. assert Z

If feature deals with theme / UI or internal elements used also in CARTO 3, please also add a note on how to do acceptance on that part.

Basic checklist

github-actions[bot] commented 7 months ago

Pull Request Test Coverage Report for Build 8753292311

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/custom-components/echarts-for-react/index.js 6 7 85.71%
packages/react-ui/src/widgets/TimeSeriesWidgetUI/hooks/useTimeSeriesInteractivity.js 1 6 16.67%
<!-- Total: 7 13 53.85% -->
Totals Coverage Status
Change from base Build 8736848869: 0.02%
Covered Lines: 2804
Relevant Lines: 3625

💛 - Coveralls
github-actions[bot] commented 7 months ago

Visit the preview URL for this PR (updated for commit 612b93c):

https://cartodb-fb-storybook-react-dev--pr865-zbigg-fix-timese-mj6tc0du.web.app

(expires Fri, 26 Apr 2024 12:16:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c