CartoDB / carto-react

CARTO for React packages

https://docs.carto.com/react/

MIT License

38 stars 16 forks source link

fix(core): Add getUTCMonday, fix tests in U.S. timezone #879

Closed donmccurdy closed 4 months ago

donmccurdy commented 4 months ago

Description

Currently the tests do not pass when running locally from a U.S. time zone, fixed in this PR. Existing code in groupByDate.js used UTC time for all groupings, and TimeSeriesWidget uses local time, but both call into getMonday which cannot do both ... so I think it's likely that a UTC-specific version of getMonday is required.

Changes:

getMonday: Returns midnight (local time) on the Monday preceeding a given date, in milliseconds since the UNIX epoch.
getUTCMonday: Returns midnight (UTC) on the Monday preceeding a given date, in milliseconds since the UNIX epoch.

github-actions[bot] commented 4 months ago

Pull Request Test Coverage Report for Build 9505380995

Details

7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 71.245%

Totals
Change from base Build 9485566432:	0.04%
Covered Lines:	2811
Relevant Lines:	3635

💛 - Coveralls

github-actions[bot] commented 4 months ago

Pull Request Test Coverage Report for Build 9505380995

Details

7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 71.245%

Totals
Change from base Build 9485566432:	0.04%
Covered Lines:	2811
Relevant Lines:	3635

💛 - Coveralls

github-actions[bot] commented 4 months ago

Visit the preview URL for this PR (updated for commit 0e81c14):

https://cartodb-fb-storybook-react-dev--pr879-fix-timezone-agn-tzpdwud3.web.app

_{(expires Fri, 21 Jun 2024 13:34:42 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c}

github-actions[bot] commented 4 months ago

Pull Request Test Coverage Report for Build 9505380995

Details

7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 71.245%

Totals
Change from base Build 9485566432:	0.04%
Covered Lines:	2811
Relevant Lines:	3635

💛 - Coveralls

github-actions[bot] commented 4 months ago

Pull Request Test Coverage Report for Build 9505453641

Details

7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 71.245%

Totals
Change from base Build 9485566432:	0.04%
Covered Lines:	2811
Relevant Lines:	3635

💛 - Coveralls

github-actions[bot] commented 4 months ago

Pull Request Test Coverage Report for Build 9505453641

Details

7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 71.245%

Totals
Change from base Build 9485566432:	0.04%
Covered Lines:	2811
Relevant Lines:	3635

💛 - Coveralls

github-actions[bot] commented 4 months ago

Pull Request Test Coverage Report for Build 9505453641

Details

7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 71.245%

Totals
Change from base Build 9485566432:	0.04%
Covered Lines:	2811
Relevant Lines:	3635

💛 - Coveralls

donmccurdy commented 4 months ago

@vmilan changelog updated, thank you!

github-actions[bot] commented 4 months ago

Pull Request Test Coverage Report for Build 9516971163

Details

7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 71.245%

Totals
Change from base Build 9515608873:	0.04%
Covered Lines:	2811
Relevant Lines:	3635

💛 - Coveralls

github-actions[bot] commented 4 months ago

Pull Request Test Coverage Report for Build 9516971163

Details

7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 71.245%

Totals
Change from base Build 9515608873:	0.04%
Covered Lines:	2811
Relevant Lines:	3635

💛 - Coveralls

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9516971163

Details

7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 71.245%

Totals
Change from base Build 9515608873:	0.04%
Covered Lines:	2811
Relevant Lines:	3635

💛 - Coveralls