CartoDB / carto-react

CARTO for React packages
https://docs.carto.com/react/
MIT License
38 stars 16 forks source link

Remote spatial index widgets #2 #910

Closed zbigg closed 1 month ago

zbigg commented 2 months ago

Description

Shortcut: https://app.shortcut.com/cartoteam/story/425306

Notable change:

If dynamic spatial index tileset source added with addSource has dataResoultion or spatialFiltersResolution widgets will run in "remote" mode.

Type of change

(choose one and remove the others)

Acceptance

N/A If feature deals with theme / UI or internal elements used also in CARTO 3, please also add a note on how to do acceptance on that part.

Basic checklist

github-actions[bot] commented 2 months ago

Visit the preview URL for this PR (updated for commit b70c804):

https://cartodb-fb-storybook-react-dev--pr910-feature-sc-42530-ytlvv8xp.web.app

(expires Mon, 07 Oct 2024 07:50:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

github-actions[bot] commented 2 months ago

Pull Request Test Coverage Report for Build 11101661308

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-widgets/src/hooks/useWidgetFetch.js 0 2 0.0%
packages/react-widgets/src/models/spatialFiltersResolution.js 6 28 21.43%
<!-- Total: 12 36 33.33% -->
Files with Coverage Reduction New Missed Lines %
packages/react-widgets/src/hooks/useWidgetFetch.js 1 80.65%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 11050451510: -0.3%
Covered Lines: 2893
Relevant Lines: 3749

💛 - Coveralls