http://libs.cartocdn.com/cartodb.js/v3/cartodb.js is not serving latest minor version of v3

CartoDB / carto.js

CartoDB javascript library

BSD 3-Clause "New" or "Revised" License

426 stars 264 forks source link

http://libs.cartocdn.com/cartodb.js/v3/cartodb.js is not serving latest minor version of v3 #923

Closed alonsogarciapablo closed 7 years ago

alonsogarciapablo commented 8 years ago

http://libs.cartocdn.com/cartodb.js/v3/cartodb.js is serving version 3.11.23 but there're more modern versions (3.11.38). We should fix it.

cc// @iriberri

iriberri commented 8 years ago

:_)

cc @ernesmb @oriolbx @ztephm @michellechandra

ghost commented 8 years ago

Wouldn't this URL be more suited to serving the latest/last stable? Or maybe it's better to "pin" to a certain version, like https://cartodb-libs.global.ssl.fastly.net/cartodb.js/v3/3.15.8/cartodb.js

Offtopic:

https://cartodb-libs.global.ssl.fastly.net/cartodb.js/v3/3.15.8/cartodb.js.map should point to a sourcemap (although maybe it needs to be called cartodb.min.js)
I don't think the other URLs like cartodb.uncompressed.js or cartodb.nojquery.js are documented anywhere

techieshark commented 8 years ago

+1 for the offtopic suggestion of better documenting the other carto URLs. I remember being surprised when I learned that cartodb.js was including things like jQuery and Mustache (I later shaved off a few bytes in my code by using carto's Mustache rather than including that library twice).

ghost commented 8 years ago

I probably should edit that comment and open a separate issue.

ghost commented 8 years ago

Ping on this issue (for my code, I've pinned a version)

iriberri commented 8 years ago

@voltagex the team decided to deprecate this un-pinned version. The problem that we are facing is that the URL is still serving an old CartoDB.js version which is incompatible with latest changes in the plaftorm.

It serves 3.11.23, whereas the 3.11 version that is compatible with the changes we did in layers is the 3.11.38. The fact that the un-versioned URL is widely shared among examples and question forums in the Internet is affecting lots of users because of the incompatibility of 3.11.23 with the current layers definition in CartoDB.

The proposal was to keep this un-versioned URL deprecated, but it would be serving 3.11.38, which will fix any layer related issue that might be appearing after our platform change. This would not break compatibility in the apps that are currently using it because it would still be serving 3.11.

nobuti commented 7 years ago

There has been no activity on this issue for several months and that's why we are closing it (automatically). If you think this still needs to be addressed please reopen it. The good news is that we are now working on the next version of CARTO.js, stay tuned.