Don't rely on regexp to identify non explainable queries

CartoDB / cartodb-postgresql

PostgreSQL extension for CartoDB

BSD 3-Clause "New" or "Revised" License

111 stars 53 forks source link

Don't rely on regexp to identify non explainable queries #335

Closed javitonino closed 6 years ago

javitonino commented 6 years ago

CartoDB/support#1669

The regexp was not correctly matching all SELECTs. For example, if it was prefixed by a parenthesis, the query could still eb valid, but the query tables code would ignore it.

We tried to fix this via improved regexp in the past: https://github.com/CartoDB/cartodb-postgresql/pull/68. This PRs relies in errors from the EXPLAIN instead.