CartoDB / cartodb-postgresql

PostgreSQL extension for CartoDB
BSD 3-Clause "New" or "Revised" License
111 stars 53 forks source link

PG federated tables listing #381

Closed rafatower closed 5 years ago

rafatower commented 5 years ago

This implements listing of remote schemas and tables, from a federated server, registered or not.

A few important remarks:

@Algunenano at this point I'm more concerned about the interface and the relations between the functions than in the implementation. What do you think?

Thanks!

Algunenano commented 5 years ago

It does not depend on any extra extension (e.g dblink nor patches in postgres_fdw) This is great.

@Algunenano at this point I'm more concerned about the interface and the relations between the functions than in the implementation. What do you think?

Agreed. This is going to break against the conventions I'm using for the other functions. Do you mind if I take these functions and incorporate them into my branch / PR in a consistent way?

IMO there should be functions to list registered tables and to list ALL foreign tables (registered or not). API-wise this may be solved by adding a column registered bool IF we have a solid convention to place federated objects and at the expense of complexity.

I'm going to keep them separated for now, we can join them before merge / release.

rafatower commented 5 years ago

Do you mind if I take these functions and incorporate them into my branch / PR in a consistent way?

Not at all! On the contrary, I really appreciate it :heart: Glad we're not stepping too much on each other's toes too.

rafatower commented 5 years ago

Closing in favor of Raul's branch