CartoDB / cartodb

Location Intelligence & Data Visualization tool
http://carto.com
BSD 3-Clause "New" or "Revised" License
2.75k stars 650 forks source link

Mapzen isoline tracts support #11723

Closed nobuti closed 7 years ago

nobuti commented 7 years ago

Mapzen isolines support, by now, a max of 4 contours (tracts). You can check it with this request:

http://matrix.mapzen.com//isochrone?json={"locations": [{"lat": 40.42028, "lon": -3.70568}], "costing": "pedestrian", "polygon": true, "contours": [{"color": "tbd", "time": 5}, {"color": "tbd", "time": 15}, {"color": "tbd", "time": 20}, {"color": "tbd", "time": 25}, {"color": "tbd", "time": 30}]}&api_key={{matrix_api_key}}

the result for that request is:

{
  "error_code": 152,
  "error": "Exceeded max contours:4",
  "status_code": 400,
  "status": "Bad Request"
}

We need to apply this constraint in the UI for the isolines analysis form. Right now, the maximum is 6 no matter which the provider it is (mapzen or heremaps).

xavijam commented 7 years ago

Hey, take into account we don't know anything about providers in the frontend...

nobuti commented 7 years ago

We do now with the data from the API. We need to define the default when the API is not there.

El 8 mar. 2017 13:24, "Javier Álvarez Medina" notifications@github.com escribió:

Hey, take into account we don't know anything about providers in the frontend...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CartoDB/cartodb/issues/11723#issuecomment-285027505, or mute the thread https://github.com/notifications/unsubscribe-auth/ABTbOzPls6bA52qfcYO4mZrdpvoSxmNWks5rjp4HgaJpZM4MWsMR .

xavijam commented 7 years ago

I strong believe frontend side should not know anything about providers, and we should not check anything about it. But in any case, this ticket should be done after the quotas thing then...

saleiva commented 7 years ago

guysm let's put 4 as max for the time being for everything

jorgesancha commented 7 years ago

Is there a way for us to see how many times we are getting that error? It should be fixed anyhow, but I want to get a sense of how big of a problem this is

xavijam commented 7 years ago

4 set!