search

CartoDB / cartodb

Location Intelligence & Data Visualization tool
http://carto.com
BSD 3-Clause "New" or "Revised" License
2.75k stars 652 forks source link

copyright shows up as HTML tag in static image exports #13411

Closed andy-esch closed 6 years ago

andy-esch commented 6 years ago

Context

When a static image is exported from Builder, the attribution includes the HTML © instead of ©.

untitled map 8

Steps to Reproduce

  1. Export an image from a map using the 'Export image...' option in the map dropdown:

    screen shot 2018-01-16 at 11 18 44

  2. Download the image and open it

  3. Note the attribution includes the HTML for the copyright symbol

Current Result

HTML tag instead of symbol

Expected result

© should show up as ©

Browser and version

Firefox 57.0.4, macOS 10.13.2

.carto file

Untitled Map 8 (on 2018-01-16 at 16.20.36).carto.zip

Additional info

None

rubenmoya commented 6 years ago

Unable to reproduce using Chrome, Safari and Firefox in macOS Sierra 10.12.6 :(

andy-esch commented 6 years ago

I just did an image export and got the same result with the &copy:

untitled map 10

I tried two different maps made recently -- both had the © in the image export.

Firefox 59.02, macOS 10.13.4

Jesus89 commented 6 years ago

Hi @andy-esch,

Could you check Export Image again with the latest version? I have obtained: test

andy-esch commented 6 years ago

I tried Safari, Firefox, and Chrome for new maps and ones that I've had for about a week. All of them had the © in them instead.

untitled map 13

michellemho commented 6 years ago

I am also encountering the same error.

nyc_waze_data_jams map

Chrome: Version 65.0.3325.181 (Official Build) (64-bit)

rjimenezda commented 6 years ago

I don't know if this is a config issue (basemap attribution is defined there). Maybe some servers have © in their basemap config? I'm not sure if each server has a different app_config.

In any case, I can reproduce it. For me, the basemaps collection has © instead of ©

I'll parse it client-side just to be safe.

rjimenezda commented 6 years ago

@ramiroaznar User on staging: copyright-this

I've verified that the basemaps arrive with © and the picture has ©, but feel free to take a look

ramiroaznar commented 6 years ago

untitled map

@rjimenezda is this the expected result?

rjimenezda commented 6 years ago

Yep, it shouldn't show any ©

You can verify that it has ©by opening the developer tools and writing basemaps.CARTO.voyager.attribution

ramiroaznar commented 6 years ago

LGTM! "&copy; <a href="http://www.openstreetmap.org/copyright">OpenStreetMap</a> contributors"

rjimenezda commented 6 years ago

Deployed :ship:

andy-esch commented 6 years ago

Awesome work :) Thank you!