Open jesusbotella opened 5 years ago
IMO it would be nice to split our work for this issue in at least two PRs:
[x] a shorter one, related to the movement and review of current styles (its result could be just the folder change and some internal notes on it). --> Relocate styles to the New Dashboard folder
[ ] another one on the bigger reorganization, using ITCSS (or alike) and BEM. This can have two parts:
Currently, our CSS styles are split into two folders of the repository: CSS in .vue files within components and common styles for the application which are located in
/assets/stylesheets/new-dashboard
.Given that our New Dashboard project is a self-contained project within cartodb JavaScript assets, it makes sense to move those separated styles to the New Dashboard folder and have them located all together.
Leveraging that change, we can set up a proper CSS scaffolding following any of the architectures that make sense for us (like 7-1 CSS architecture). Separating styles by concerns, instead of them being unorganized.
As an extra ball, it could be great if we could use BEM for all those common styles which are not scoped and may require a bit of effort when naming them to avoid classes collision.
To summarize:
/assets/stylesheets/new-dashboard
tolib/assets/javascripts/new-dashboard/styles
folder.