CartoDB / cartodb

Location Intelligence & Data Visualization tool
http://carto.com
BSD 3-Clause "New" or "Revised" License
2.74k stars 652 forks source link

several js errors in team public pages with https #7669

Closed matallo closed 7 years ago

matallo commented 8 years ago

I can spot several js error in the public map of organization pages when loading in https (find attached)

screen shot 2016-06-06 at 10 41 04

example: https://team.cartodb.com/u/saleiva/viz/de65584c-ed7c-11e2-a228-3085a9a9563c/public_map?redirected=true

when loading over http it looks fine, actually I think we should redirect http => https all traffic :/

/cc @luisbosque

javisantana commented 8 years ago

do you have any adblocker?

matallo commented 8 years ago

I do, but not the case, still happening in incognito and IMO this should be treated as a redirect issue, then fix it when in https

alonsogarciapablo commented 8 years ago

It looks like that particular map has been setup to use Oddysey and the maps_api_template option is not right in the slides section of the viz.json. Here's a dump of the viz.json:

{
  "id": "de65584c-ed7c-11e2-a228-3085a9a9563c",
  "version": "0.1.0",
  "title": "Baltimore vacant buildings crime",
  "likes": 1,
  "description": "<p>Vacant properties catalogued on OpenBaltimore (purple) vs shootings and homicides(red and blue)</p>\n",
  "scrollwheel": true,
  "legends": true,
  "url": null,
  "map_provider": "leaflet",
  "bounds": [
    [
      39.28721342935559,
      -76.68517112731934
    ],
    [
      39.3186284170647,
      -76.57599449157715
    ]
  ],
  "center": "[39.30292268567317, -76.63058280944824]",
  "zoom": 14,
  "updated_at": "2016-05-05T13:20:36+00:00",
  "layers": [
    {
      "options": {
        "id": "5419c23d-b7cc-4b5f-8da0-9656f6d2bf40",
        "order": 0,
        "visible": true,
        "type": "Tiled",
        "name": "Positron",
        "className": "default positron_rainbow",
        "base_type": "positron_rainbow",
        "urlTemplate": "http://{s}.basemaps.cartocdn.com/light_all/{z}/{x}/{y}.png",
        "read_only": true,
        "minZoom": "0",
        "maxZoom": "18",
        "attribution": "© <a href=\"http://www.openstreetmap.org/copyright\">OpenStreetMap</a> contributors © <a href= \"http://cartodb.com/attributions#basemaps\">CartoDB</a>",
        "subdomains": "abcd",
        "category": "CartoDB"
      },
      "infowindow": null,
      "tooltip": null,
      "id": "5419c23d-b7cc-4b5f-8da0-9656f6d2bf40",
      "order": 0,
      "type": "tiled"
    },
    {
      "type": "layergroup",
      "options": {
        "user_name": "saleiva",
        "maps_api_template": "https://{user}.cartodb.com:443",
        "sql_api_template": "https://{user}.cartodb.com:443",
        "tiler_protocol": "http",
        "tiler_domain": "cartodb.com",
        "tiler_port": "80",
        "sql_api_protocol": "http",
        "sql_api_domain": "cartodb.com",
        "sql_api_endpoint": "/api/v2/sql",
        "sql_api_port": 80,
        "filter": "mapnik",
        "layer_definition": {
          "stat_tag": "de65584c-ed7c-11e2-a228-3085a9a9563c",
          "version": "1.0.1",
          "layers": [
            {
              "id": "6b27ece7-1ff9-4c73-ad41-b771c2305f5e",
              "type": "CartoDB",
              "infowindow": {
                "fields": [],
                "template_name": "infowindow_light_header_blue",
                "template": "<div class=\"cartodb-popup header blue v2\">\n  <a href=\"#close\" class=\"cartodb-popup-close-button close\">x</a>\n  <div class=\"cartodb-popup-header\">\n    {{#content.fields}}\n      {{^index}}\n        {{#title}}<h4>{{title}}</h4>{{/title}}\n        {{#value}}\n          <h1 {{#type}}class=\"{{ type }}\"{{/type}}>{{{ value }}}</h1>\n        {{/value}}\n        {{^value}}\n          <h1 class=\"empty\">null</h1>\n        {{/value}}\n        <span class=\"separator\"></span>\n      {{/index}}\n    {{/content.fields}}\n  </div>\n  <div class=\"cartodb-popup-content-wrapper\">\n    <div class=\"cartodb-popup-content\">\n      {{#content.fields}}\n        {{#index}}\n          {{#title}}<h4>{{title}}</h4>{{/title}}\n          {{#value}}\n            <p>{{{ value }}}</p>\n          {{/value}}\n          {{^value}}\n            <p class=\"empty\">null</p>\n          {{/value}}\n        {{/index}}\n      {{/content.fields}}\n    </div>\n  </div>\n  <div class=\"cartodb-popup-tip-container\">\n  </div>\n</div>",
                "alternative_names": {},
                "width": 226,
                "maxHeight": 180
              },
              "tooltip": {
                "fields": null,
                "template_name": "tooltip_light",
                "template": "<div class=\"cartodb-tooltip-content-wrapper\">\n  <div class=\"cartodb-tooltip-content\">\n  {{#fields}}\n    {{#title}}\n    <h4>{{title}}</h4>\n    {{/title}}\n    <p>{{{ value }}}</p>\n  {{/fields}}\n  </div>\n</div>",
                "alternative_names": {},
                "maxHeight": 180
              },
              "legend": {
                "type": "none",
                "show_title": false,
                "title": "",
                "template": "",
                "visible": true
              },
              "order": 1,
              "visible": true,
              "options": {
                "layer_name": "vacant_buildings",
                "cartocss": "/** intensity visualization */\n\n\n#vacant_buildings{\n  marker-fill: #A53ED5; \n  marker-width: 4; \n  marker-line-color: #FFF; \n  marker-line-width: 3; \n  marker-line-opacity: 0.9; \n  marker-fill-opacity: 0.9; \n  marker-comp-op: multiply;\n  marker-type: ellipse; \n  marker-placement: point; \n  marker-allow-overlap: true; \n  marker-clip: false; \n  marker-multi-policy: largest; \n}",
                "cartocss_version": "2.1.1",
                "interactivity": "cartodb_id",
                "sql": "select * from vacant_buildings",
                "table_name": "\"\"."
              }
            },
            {
              "id": "eb1b313d-4d3f-4f7e-a69d-6b3b2745fe43",
              "type": "CartoDB",
              "infowindow": {
                "fields": [
                  {
                    "name": "crimedate",
                    "title": true,
                    "position": 1
                  },
                  {
                    "name": "district",
                    "title": true,
                    "position": 3
                  },
                  {
                    "name": "neighborhood",
                    "title": true,
                    "position": 6
                  }
                ],
                "template_name": "infowindow_dark",
                "template": "<div class=\"cartodb-popup dark v2\">\n  <a href=\"#close\" class=\"cartodb-popup-close-button close\">x</a>\n  <div class=\"cartodb-popup-content-wrapper\">\n    <div class=\"cartodb-popup-content\">\n      {{#content.fields}}\n        {{#title}}<h4>{{title}}</h4>{{/title}}\n        {{#value}}\n          <p {{#type}}class=\"{{ type }}\"{{/type}}>{{{ value }}}</p>\n        {{/value}}\n        {{^value}}\n          <p class=\"empty\">null</p>\n        {{/value}}\n      {{/content.fields}}\n    </div>\n  </div>\n  <div class=\"cartodb-popup-tip-container\"></div>\n</div>\n",
                "alternative_names": {},
                "width": 226,
                "maxHeight": 180
              },
              "tooltip": {
                "fields": [
                  {
                    "name": "crimecode",
                    "title": true,
                    "position": 0
                  }
                ],
                "template_name": "tooltip_dark",
                "template": "<div class=\"cartodb-tooltip-content-wrapper dark\">\n  <div class=\"cartodb-tooltip-content\">\n  {{#fields}}\n    {{#title}}\n    <h4>{{title}}</h4>\n    {{/title}}\n    <p>{{{ value }}}</p>\n  {{/fields}}\n  </div>\n</div>",
                "alternative_names": {},
                "maxHeight": 180
              },
              "legend": {
                "type": "none",
                "show_title": false,
                "title": "",
                "template": ""
              },
              "order": 2,
              "visible": false,
              "options": {
                "layer_name": "shootings_bltmre",
                "cartocss": "/** simple visualization */\n\n#shootings_bltmre{\n  marker-fill-opacity: 1;\n  marker-line-color: #FFF;\n  marker-line-width: 1;\n  marker-line-opacity: 0.9;\n  marker-placement: point;\n  marker-type: ellipse;\n  marker-width: 12;\n  marker-fill: #7B00B4;\n  marker-allow-overlap: true;\n}",
                "cartocss_version": "2.1.0",
                "interactivity": "cartodb_id,crimecode",
                "sql": "select * from shootings_bltmre",
                "table_name": "\"\"."
              }
            },
            {
              "id": "3560ba47-3a82-4f9c-8191-2b63ae770ad7",
              "type": "CartoDB",
              "infowindow": {
                "fields": [
                  {
                    "name": "crimedate",
                    "title": true,
                    "position": 0
                  },
                  {
                    "name": "neighborhood",
                    "title": true,
                    "position": 6
                  },
                  {
                    "name": "weapon",
                    "title": true,
                    "position": 8
                  }
                ],
                "template_name": "infowindow_dark",
                "template": "<div class=\"cartodb-popup dark v2\">\n  <a href=\"#close\" class=\"cartodb-popup-close-button close\">x</a>\n  <div class=\"cartodb-popup-content-wrapper\">\n    <div class=\"cartodb-popup-content\">\n      {{#content.fields}}\n        {{#title}}<h4>{{title}}</h4>{{/title}}\n        {{#value}}\n          <p {{#type}}class=\"{{ type }}\"{{/type}}>{{{ value }}}</p>\n        {{/value}}\n        {{^value}}\n          <p class=\"empty\">null</p>\n        {{/value}}\n      {{/content.fields}}\n    </div>\n  </div>\n  <div class=\"cartodb-popup-tip-container\"></div>\n</div>\n",
                "alternative_names": {},
                "width": 240,
                "maxHeight": 180
              },
              "tooltip": {
                "fields": [],
                "template_name": "tooltip_light",
                "template": "<div class=\"cartodb-tooltip-content-wrapper\">\n  <div class=\"cartodb-tooltip-content\">\n  {{#fields}}\n    {{#title}}\n    <h4>{{title}}</h4>\n    {{/title}}\n    <p>{{{ value }}}</p>\n  {{/fields}}\n  </div>\n</div>",
                "alternative_names": {},
                "maxHeight": 180
              },
              "legend": {
                "type": "category",
                "show_title": false,
                "title": "",
                "template": "",
                "items": [
                  {
                    "name": "SHOOTING",
                    "visible": true,
                    "value": "#FFCC00"
                  },
                  {
                    "name": "HOMICIDE",
                    "visible": true,
                    "value": "#B40903"
                  }
                ]
              },
              "order": 3,
              "visible": true,
              "options": {
                "layer_name": "shootings_and_homicides_bltmre",
                "cartocss": "/** category visualization */\n\n#shootings_and_homicides_bltmre {\n   marker-fill-opacity: 0.9;\n   marker-line-color: #FFF;\n   marker-line-width: 1.5;\n   marker-line-opacity: 1;\n   marker-placement: point;\n   marker-type: ellipse;\n   marker-width: 10;\n   marker-allow-overlap: true;\n}\n\n#shootings_and_homicides_bltmre[description=\"SHOOTING\"] {\n   marker-fill: #FFCC00;\n}\n#shootings_and_homicides_bltmre[description=\"HOMICIDE\"] {\n   marker-fill: #B40903;\n}",
                "cartocss_version": "2.1.0",
                "interactivity": "cartodb_id",
                "sql": "select * from shootings_and_homicides_bltmre",
                "table_name": "\"\"."
              }
            }
          ]
        },
        "attribution": ""
      }
    }
  ],
  "overlays": [
    {
      "type": "annotation",
      "order": 1,
      "options": {
        "device": "desktop",
        "display": true,
        "style": {
          "z-index": 4,
          "color": "#ffffff",
          "text-align": "left",
          "font-size": "13",
          "font-family-name": "Helvetica",
          "box-color": "#000000",
          "box-opacity": 0.7,
          "box-padding": 5,
          "line-color": "#000000",
          "line-width": 50,
          "min-zoom": 0,
          "max-zoom": 18
        },
        "extra": {
          "latlng": [
            39.30348722334712,
            -76.62938117980957
          ],
          "text": "I'm an **annotation overlay**",
          "rendered_text": "I&#39;m an <strong>annotation overlay</strong>"
        }
      },
      "template": null
    },
    {
      "type": "zoom",
      "order": 6,
      "options": {
        "display": true,
        "x": 20,
        "y": 20
      },
      "template": "<a href=\"#zoom_in\" class=\"zoom_in\">+</a> <a href=\"#zoom_out\" class=\"zoom_out\">-</a>"
    },
    {
      "type": "loader",
      "order": 8,
      "options": {
        "display": true,
        "x": 20,
        "y": 150
      },
      "template": "<div class=\"loader\" original-title=\"\"></div>"
    }
  ],
  "prev": null,
  "next": null,
  "transition_options": {
    "time": 0
  },
  "slides": [
    {
      "id": "cca8baea-ad29-11e4-9c4a-0e018d66dc29",
      "version": "0.1.0",
      "title": "Baltimore vacant buildings crime",
      "likes": 0,
      "description": "<p>Vacant properties catalogued on OpenBaltimore (purple) vs shootings and homicides(red and blue)</p>\n",
      "scrollwheel": true,
      "legends": true,
      "url": null,
      "map_provider": "leaflet",
      "bounds": [
        [
          39.26701538170104,
          -76.70190811157227
        ],
        [
          39.32081963420592,
          -76.53925895690918
        ]
      ],
      "center": "[39.293922676164385, -76.62058353424072]",
      "zoom": 14,
      "updated_at": "2015-07-15T12:06:18+00:00",
      "layers": [
        {
          "options": {
            "id": "65778bcd-7c1b-4975-b57f-56b5c839cbd1",
            "order": 0,
            "visible": true,
            "type": "Tiled",
            "name": "Positron",
            "className": "positron_rainbow_labels",
            "base_type": "default",
            "urlTemplate": "http://{s}.basemaps.cartocdn.com/light_nolabels/{z}/{x}/{y}.png",
            "minZoom": "0",
            "maxZoom": "18",
            "attribution": "&copy; <a href=\"http://www.openstreetmap.org/copyright\">OpenStreetMap</a> contributors &copy; <a href= \"http://cartodb.com/attributions\">CartoDB</a>",
            "subdomains": "abcd",
            "style": null,
            "labels": {
              "url": "http://{s}.basemaps.cartocdn.com/light_only_labels/{z}/{x}/{y}.png"
            },
            "read_only": true,
            "category": "CartoDB"
          },
          "infowindow": null,
          "tooltip": null,
          "id": "65778bcd-7c1b-4975-b57f-56b5c839cbd1",
          "order": 0,
          "type": "tiled"
        },
        {
          "type": "layergroup",
          "options": {
            "user_name": "saleiva",
            "maps_api_template": "http://{user}.cartodb.com:80",
            "sql_api_template": "http://{user}.cartodb.com:80",
            "tiler_protocol": "http",
            "tiler_domain": "cartodb.com",
            "tiler_port": "80",
            "sql_api_protocol": "http",
            "sql_api_domain": "cartodb.com",
            "sql_api_endpoint": "/api/v2/sql",
            "sql_api_port": 80,
            "filter": "mapnik",
            "layer_definition": {
              "stat_tag": "cca8baea-ad29-11e4-9c4a-0e018d66dc29",
              "version": "1.0.1",
              "layers": [
                {
                  "id": "78f2d32a-2e6e-4ab0-81d5-286b447910b4",
                  "type": "CartoDB",
                  "infowindow": {
                    "fields": [],
                    "template_name": "infowindow_light_header_blue",
                    "template": "<div class=\"cartodb-popup header blue v2\">\n  <a href=\"#close\" class=\"cartodb-popup-close-button close\">x</a>\n  <div class=\"cartodb-popup-header\">\n    {{#content.fields}}\n      {{^index}}\n        {{#title}}<h4>{{title}}</h4>{{/title}}\n        {{#value}}\n          <h1 {{#type}}class=\"{{ type }}\"{{/type}}>{{{ value }}}</h1>\n        {{/value}}\n        {{^value}}\n          <h1 class=\"empty\">null</h1>\n        {{/value}}\n        <span class=\"separator\"></span>\n      {{/index}}\n    {{/content.fields}}\n  </div>\n  <div class=\"cartodb-popup-content-wrapper\">\n    <div class=\"cartodb-popup-content\">\n      {{#content.fields}}\n        {{#index}}\n          {{#title}}<h4>{{title}}</h4>{{/title}}\n          {{#value}}\n            <p>{{{ value }}}</p>\n          {{/value}}\n          {{^value}}\n            <p class=\"empty\">null</p>\n          {{/value}}\n        {{/index}}\n      {{/content.fields}}\n    </div>\n  </div>\n  <div class=\"cartodb-popup-tip-container\">\n  </div>\n</div>",
                    "alternative_names": {},
                    "width": 226,
                    "maxHeight": 180
                  },
                  "tooltip": {
                    "fields": null,
                    "template_name": "tooltip_light",
                    "template": "<div class=\"cartodb-tooltip-content-wrapper\">\n  <div class=\"cartodb-tooltip-content\">\n  {{#fields}}\n    {{#title}}\n    <h4>{{title}}</h4>\n    {{/title}}\n    <p>{{{ value }}}</p>\n  {{/fields}}\n  </div>\n</div>",
                    "alternative_names": {},
                    "maxHeight": 180
                  },
                  "legend": {
                    "type": "none",
                    "show_title": false,
                    "title": "",
                    "template": "",
                    "visible": true
                  },
                  "order": 1,
                  "visible": true,
                  "options": {
                    "layer_name": "vacant_buildings",
                    "cartocss": "/** intensity visualization */\n\n\n#vacant_buildings{\n  marker-fill: #A53ED5; \n  marker-width: 4; \n  marker-line-color: #FFF; \n  marker-line-width: 3; \n  marker-line-opacity: 0.9; \n  marker-opacity: 0.9; \n  marker-comp-op: multiply; \n  marker-type: ellipse; \n  marker-placement: point; \n  marker-allow-overlap: true; \n  marker-clip: false; \n  marker-multi-policy: largest; \n}",
                    "cartocss_version": "2.1.1",
                    "interactivity": "cartodb_id",
                    "sql": "select * from vacant_buildings",
                    "table_name": "\"\"."
                  }
                },
                {
                  "id": "140f2252-7f91-4d21-bd04-c9e9fb036cc3",
                  "type": "CartoDB",
                  "infowindow": {
                    "fields": [
                      {
                        "name": "crimedate",
                        "title": true,
                        "position": 0
                      },
                      {
                        "name": "neighborhood",
                        "title": true,
                        "position": 6
                      },
                      {
                        "name": "weapon",
                        "title": true,
                        "position": 8
                      }
                    ],
                    "template_name": "infowindow_dark",
                    "template": "<div class=\"cartodb-popup dark v2\">\n  <a href=\"#close\" class=\"cartodb-popup-close-button close\">x</a>\n  <div class=\"cartodb-popup-content-wrapper\">\n    <div class=\"cartodb-popup-content\">\n      {{#content.fields}}\n        {{#title}}<h4>{{title}}</h4>{{/title}}\n        {{#value}}\n          <p {{#type}}class=\"{{ type }}\"{{/type}}>{{{ value }}}</p>\n        {{/value}}\n        {{^value}}\n          <p class=\"empty\">null</p>\n        {{/value}}\n      {{/content.fields}}\n    </div>\n  </div>\n  <div class=\"cartodb-popup-tip-container\"></div>\n</div>\n",
                    "alternative_names": {},
                    "width": 240,
                    "maxHeight": 180
                  },
                  "tooltip": {
                    "fields": [],
                    "template_name": "tooltip_light",
                    "template": "<div class=\"cartodb-tooltip-content-wrapper\">\n  <div class=\"cartodb-tooltip-content\">\n  {{#fields}}\n    {{#title}}\n    <h4>{{title}}</h4>\n    {{/title}}\n    <p>{{{ value }}}</p>\n  {{/fields}}\n  </div>\n</div>",
                    "alternative_names": {},
                    "maxHeight": 180
                  },
                  "legend": {
                    "type": "category",
                    "show_title": false,
                    "title": "",
                    "template": "",
                    "visible": true,
                    "items": [
                      {
                        "name": "SHOOTING",
                        "visible": true,
                        "value": "#FFCC00"
                      },
                      {
                        "name": "HOMICIDE",
                        "visible": true,
                        "value": "#F11810"
                      }
                    ]
                  },
                  "order": 2,
                  "visible": true,
                  "options": {
                    "layer_name": "shootings_and_homicides_bltmre",
                    "cartocss": "/** category visualization */\n\n#shootings_and_homicides_bltmre {\n   marker-fill-opacity: 0.9;\n   marker-line-color: #FFF;\n   marker-line-width: 1.5;\n   marker-line-opacity: 1;\n   marker-placement: point;\n   marker-type: ellipse;\n   marker-width: 10;\n   marker-allow-overlap: true;\n}\n\n#shootings_and_homicides_bltmre[description=\"SHOOTING\"] {\n   marker-fill: #FFCC00;\n}\n#shootings_and_homicides_bltmre[description=\"HOMICIDE\"] {\n   marker-fill: #F11810;\n}",
                    "cartocss_version": "2.1.0",
                    "interactivity": "cartodb_id",
                    "sql": "select * from shootings_and_homicides_bltmre",
                    "table_name": "\"\"."
                  }
                }
              ]
            },
            "attribution": ""
          }
        },
        {
          "options": {
            "visible": true,
            "type": "Tiled",
            "name": "Positron Labels",
            "urlTemplate": "http://{s}.basemaps.cartocdn.com/light_only_labels/{z}/{x}/{y}.png",
            "attribution": "&copy; <a href=\"http://www.openstreetmap.org/copyright\">OpenStreetMap</a> contributors &copy; <a href= \"http://cartodb.com/attributions\">CartoDB</a>",
            "minZoom": "0",
            "maxZoom": "18",
            "subdomains": "abcd",
            "kind": "tiled",
            "order": 3
          },
          "infowindow": null,
          "tooltip": null,
          "id": "69482541-2e79-4dd4-bc48-4d90bebbd451",
          "order": 3,
          "type": "tiled"
        }
      ],
      "overlays": [
        {
          "type": "zoom",
          "order": 6,
          "options": {
            "display": true,
            "x": 20,
            "y": 20
          },
          "template": "<a href=\"#zoom_in\" class=\"zoom_in\">+</a> <a href=\"#zoom_out\" class=\"zoom_out\">-</a>"
        },
        {
          "type": "loader",
          "order": 8,
          "options": {
            "display": true,
            "x": 20,
            "y": 150
          },
          "template": "<div class=\"loader\" original-title=\"\"></div>"
        }
      ],
      "prev": null,
      "next": null,
      "transition_options": {
        "time": 0
      }
    }
  ]
}
matallo commented 7 years ago

it looks like after the migration this is not happening anymore. Closing then!