CartoDB / cartoframes

CARTO Python package for data scientists
BSD 3-Clause "New" or "Revised" License
251 stars 63 forks source link

Fix empty popups #1689

Closed antoniocarlon closed 4 years ago

antoniocarlon commented 4 years ago

In a map with several layers CF allows us to define different behaviors for the popups of the different layer, but in the front-end the behavior of the popups is defined by map (instead of by layer).

This PR removes the popups from the entities that show empty ones. It's not the ideal fix but the perfect fix would force us to revisit the Map and Layer models (and maybe the Feature one, not sure...).

For now this PR should be harmless because it only removes completely empty popups (if the popup shows the name of the feld it won't be removed), and it works for both hover and click popups