search

CartoDB / crankshaft

CARTO Spatial Analysis extension for PostgreSQL
BSD 3-Clause "New" or "Revised" License
54 stars 20 forks source link

Add PARALLEL support #183

Closed Algunenano closed 6 years ago

Algunenano commented 6 years ago

Add PARALLEL and VOLATILE tags for Postgresql functions

Algunenano commented 6 years ago

After some final fixes I think this should be done with the PR.

Algunenano commented 6 years ago

Solves https://github.com/CartoDB/crankshaft/issues/181

Algunenano commented 6 years ago

I'd be nice to copy the volatility and "parallelizability" guidelines in the CONTRIBUTING.md as well here. Will do

Algunenano commented 6 years ago

Rebased with fix for bsd-systems compatibility (as https://github.com/CartoDB/cartodb-postgresql/pull/315)

Algunenano commented 6 years ago

Rebased on top of GWR introduction and added categories to the new functions.

It'd nice if we could merge this and deploy it with GWR so we don't have to do 2 different deploys. cc/ @andy-esch @jgoizueta Related to this, a warning has appeared when running python tests: https://github.com/CartoDB/crankshaft/issues/188

Algunenano commented 6 years ago

After checking the deploy method with @jgoizueta I''ve seen that this projects commits release files (cartodb-postgresql doesn't) so instead of stripping the PARALLEL labels when generating the release file we need to do it in the deploy phase. Should be ok with this last commit.

Also we've decided to do 2 different deploys.

rafatower commented 6 years ago

:+1: