Closed rafatower closed 6 years ago
Hey @andy-esch: I could not come up with a python unit test for this case. I think that adding a sql test for it makes little sense, and since it does not break any test, if you don't have any problem with it I'd go ahead with this change and release along with your other changes in develop branch.
That sounds good to me. I successfully installed this branch locally and all the tests (python and sql) passed.
This solves a problem with the Markov analysis. Otherwise, with some inputs it gives the following error:
The stack trace is the following:
and here is the line where it actually fails: https://github.com/pysal/pysal/blob/v1.11.2/pysal/spatial_dynamics/markov.py#L526
In v1.14.3, the
shtest
is opt-in. So this gives us a chance to curate data if we wanted to apply that test, optionally, instead of crashing:https://github.com/pysal/pysal/blob/v1.14.3/pysal/spatial_dynamics/markov.py#L490
geometry(Geometry, 4326)
for general geoms, orgeometry(Point, 4326)
CDB_NameOfFunction
. Where internal functions begin with an underscore