Python 3 compatibility - Githubissues

Algunenano commented 4 years ago

This PR introduces python 3 compatibility to crankshaft. Some notes:

Versions 0.8.2 and prior only work with python2.
Version 0.9.0 is compatible with both python2 and python3. The python version selected defaults to python3 if deploying against PG12+, or python2 for previous releases. The python version is decided on deployment, not on release.
Any new release targets python3. It will do magic to deploy 0.9.0+ releases to PG versions prior to PG12 (same thing that it does with PARALLEL tags for pre 9.6).
The idea is to update to 0.9.0 to everyone, so they have code compatible to python2 and python3. This will require some testing.

I'm including both @andy-esch and @rafatower in the PR because you are the engineers with most contributions to the repo that are still working at CARTO. Feel free to ignore it if you are busy.

andy-esch commented 4 years ago

Hey @Algunenano, I took a look through and looks ok to me. Thanks for tackling this!

rafatower commented 4 years ago

Post merge silly review: I went through the changes and they look good to me. I largely ignored release /0.9.0/ files (either that or die). By looking at the code, cannot tell whether it's actually compatible with python2 & python3, but very glad travis checks that for us. Great job, thanks! :+1:

CartoDB / crankshaft

Python 3 compatibility #214