search

CartoDB / d3.cartodb

Client-side rendering of CartoDB visualisations with d3
BSD 3-Clause "New" or "Revised" License
30 stars 6 forks source link

Multitype one pass #151

Closed rochoa closed 8 years ago

rochoa commented 8 years ago

Similar to #150 but doing everything within append operation. It uses dom methods to manipulate element attributes.

There is no much difference in terms of performance from #150 so I would go with that other one.

What do you thing @fdansv?

fdansv commented 8 years ago

Yeah at least for the sake of clarity I'd go with the other one. Also here we're not using anymore the enter/exit selections for d3, which might gives us problems in the future, especially considering #122

rochoa commented 8 years ago

Closing it as the performance gain doesn't justify being less clear about what we want to achieve.