search

CartoDB / data-services

CARTO internal geocoder PostgreSQL extension
25 stars 11 forks source link

Update admin1 geocoder function to use new synonyms table #18

Open andrewxhill opened 10 years ago

andrewxhill commented 10 years ago

https://github.com/CartoDB/data-services/wiki/Geocoder-synonym-tables

andrewxhill commented 10 years ago

depends on https://github.com/CartoDB/data-services/issues/20

andrewxhill commented 10 years ago

@clhenrick

I've added a column 'adm0_a3' to the admin0_synonyms table. I've written all the content from from country_iso3 to the new column. let's deprecate country_iso3 and delete it if you are not using it.

I'm going to use adm0_a3 as the primary key for countries in both the synonym and data tables.

woeid wont work. i see duplicate IDs, especially the negative values... so we should not use woeid unfortunately.

clhenrick commented 10 years ago

okay that makes sense, I was also feeling skeptical about the woe_id.

On Wed, Jul 30, 2014 at 5:08 PM, Andrew W. Hill notifications@github.com wrote:

@clhenrick https://github.com/clhenrick

I've added a column 'adm0_a3' to the admin0_synonyms table. I've written all the content from from country_iso3 to the new column. let's deprecate country_iso3 and delete it if you are not using it.

I'm going to use adm0_a3 as the primary key for countries in both the synonym and data tables.

woeid wont work. i see duplicate IDs, especially the negative values... so we should not use woeid unfortunately.

— Reply to this email directly or view it on GitHub https://github.com/CartoDB/data-services/issues/18#issuecomment-50680198 .

-Chris

andrewxhill commented 10 years ago

Can you update the https://github.com/CartoDB/data-services/wiki/Geocoder-synonym-tables with the column name change?

michesteva commented 10 years ago

So, I should exclude woeid mention from the geocode landing page description?

andrewxhill commented 10 years ago

yes, definitely. the landing page shouldn't talk to much about the technical details. just the source and function. so what types of text can a user turn into geospatial data? and in some cases, what is the source of that great data

michesteva commented 10 years ago

Got it. Chris walked me through the back-end sources.