CartoDB / dataservices-api

The CARTO Data Services API
https://carto.com/docs/carto-engine/dataservices-api/
BSD 3-Clause "New" or "Revised" License
22 stars 14 forks source link

Feature/ch115970/support new here api keys #622

Closed Mmoncadaisla closed 3 years ago

Mmoncadaisla commented 3 years ago

Context

This PR aims to add support for new HERE API authentication method through the apikey param (as opposed to app_code and app_id) for Geocoding (serial and bulk) and Isolines Location Data Services, using the new HERE API versions when possible (serial geocoder and isolines services).

Changes have been performed following the HERE migration guides:

For further context please see the CH Story: https://app.clubhouse.io/cartoteam/story/115970/support-new-here-api-keys

NOTE: All the changes have been performed in the dataservices-api server side and should not affect the current behavior.

Main additions

Usage

The new functionality can be set through the use_apikey (boolean) and apikey (string) parameters at the dataservices_db cdb_conf table level through the CDB_Conf_SetConf function as described in the README.

Relevant code changes

SQL

Changes in the corresponding SQL functions to make use of the service_factory functions.

Python (cartodb_services package)

shortcut-integration[bot] commented 3 years ago

This pull request has been linked to Clubhouse Story #115970: Support new HERE api keys.

Mmoncadaisla commented 3 years ago

Thank you a lot for your help and suggestions @Shylpx!! just included these, could you please take a look when time? 🙂

Mmoncadaisla commented 3 years ago

@Jesus89 it seems that there are two tests failing which are (apparently) unrelated to this PR,

Should we go ahead and try to fix them as part of this PR? In that case, do you have any suggestions in order to handle the broken test related to the nose dependency?