Closed Mmoncadaisla closed 3 years ago
This pull request has been linked to Clubhouse Story #115970: Support new HERE api keys.
Thank you a lot for your help and suggestions @Shylpx!! just included these, could you please take a look when time? 🙂
@Jesus89 it seems that there are two tests failing which are (apparently) unrelated to this PR,
nose
not being found Should we go ahead and try to fix them as part of this PR? In that case, do you have any suggestions in order to handle the broken test related to the nose
dependency?
Context
This PR aims to add support for new HERE API authentication method through the
apikey
param (as opposed toapp_code
andapp_id
) for Geocoding (serial and bulk) and Isolines Location Data Services, using the new HERE API versions when possible (serial geocoder and isolines services).Changes have been performed following the HERE migration guides:
https://developer.here.com/documentation/geocoding-search-api/migration_guide/index.html
https://developer.here.com/documentation/routing-api/8.14.0/migration_guide/index.html
For further context please see the CH Story: https://app.clubhouse.io/cartoteam/story/115970/support-new-here-api-keys
Main additions
service_factory
module to return the corresponding HERE service depending on theuse_apikey
parameter.HereMapsRoutingIsolineV8
isolines routing functionality for HEREv8
Routing serviceHereMapsGeocoderV7
serial geocoder class for HERE Maps GS7 Geocoding serviceHereMapsBulkGeocoderV7
Adapted version of the6.2
service to be used with HERE apikeys.Usage
The new functionality can be set through the
use_apikey
(boolean) andapikey
(string) parameters at thedataservices_db
cdb_conf
table level through theCDB_Conf_SetConf
function as described in the README.Relevant code changes
SQL
Changes in the corresponding SQL functions to make use of the
service_factory
functions.Python (cartodb_services package)
flexpolyline
dependency for v8 Routing Isolines response decoding