search

CartoDB / deep-insights.js

Create powerful dashboards using CARTO
34 stars 26 forks source link

Move play / pause buttons to the side of animated time-series #561

Closed rjimenezda closed 7 years ago

rjimenezda commented 7 years ago

re: https://github.com/CartoDB/cartodb/issues/12387

Cartodb PR: https://github.com/CartoDB/cartodb/pull/12482 Deep-insights.js PR: https://github.com/CartoDB/deep-insights.js/pull/561 Cartodb.js PR: https://github.com/CartoDB/cartodb.js/pull/1701

Play button is here now:

screen shot 2017-07-17 at 12 34 19

It also does most of the job of enabling playback on a selected range, but it's not perfect on a couple of cases, so i've disabled it for now. The cartodb.js work is on the branch 12387-play-pause, which we don't need to merge ASAP.

xavijam commented 7 years ago

CR feedback applied @matallo 💋

xavijam commented 7 years ago

Our CI passing, merging!