widgets: time-series: responsive

[matallo]

re: https://github.com/CartoDB/cartodb/issues/12470

this will eventually point to master, when https://github.com/CartoDB/deep-insights.js/pull/562 is merged

---

cartodb PR: https://github.com/CartoDB/cartodb/pull/12543 deep-insights.js PR: https://github.com/CartoDB/deep-insights.js/pull/566 cartodb.js PR: https://github.com/CartoDB/cartodb.js/pull/1709

---

pulling the changes from time-series aggregations, and timezones, plus:

• [x] implemented responsive behaviour for Tablet and Mobile viewports
• [x] added timeslider tip to timeslider view, and static tips to time-slider header
• [x] added viewport utils
• [x] tests

there's only one thing I'm not specially happy about which is updating the static tips, when dragging the handles, however I couldn't find a better approach using the rangeFilter, as it is only updated on brush end

acceptance

• test time-series, animated time-series, AND normal histogram in desktop, tablet, and mobile viewport, selecting range, playing, and updating the timezone and local timezone for timestamps
• heights should vary
• timestamps should vary, and update on dragging and click interactions
• tips should change behaviour

test again with number type column, they should work as expected

check the Invision project for the designs

[matallo]

advanced a bit on the testing front, I feel the lack of specs disturbing

• [x] _updateTriangle
• [x] _updateAxisTip
• [x] _onChangeDragging
• [x] _toggleAxisTip
• [x] _hideAxisTip
• [x] _showAxisTip
• [x] _generateChartContent
• [x] _setupBrush
• [x] _generateAxisTip
• [x] _isTabletViewport
• [x] _generateHandle
• [x] _updateChart
• [x] _isMobileViewport
• [x] _generateBars
• [x] _setupFormatter

[matallo]

finished the specs, I didn't test the X position for the tip at the beginning / middle / end of the timeline, just the Y because it could be crazytown (and it wasn't actually the scope of the PR, just for the timeslider tip)

besides new methods, I'm mostly testing the cases where mobile viewports, and column type are checked to show the responsive chart

[nobuti]

Was this accepted?

[rubenmoya]

Yes, the last changes was just one test failing in Travis, but code review and acceptance were already done.