Improve widgets error state for supporting several error types

[xavijam]

When there is an error in the Dataviews request, widgets can be rendered. We display an error saying "There has been an error" (or something like that), and a refresh button (is it useful?).

From now on we should be more concrete about the problem. We should catalog those by:

• Data error: any dataview request returned an error and we should display it.
• Limits error: the user has reached its platform limits, dataview request will fail but with a specific error code or message, so we should decide if the error message should change or not (let's not forget this will be public in the embed page).

Design

*Related ticket: https://github.com/CartoDB/cartodb-platform/issues/3279

[rubenmoya]

Hi! I've seen in this issue https://github.com/CartoDB/cartodb/issues/12751 the widget error text has changed, right now, for the limits engine is sending this error:

{
  type: 'limit',
  message: 'You are over platform\'s limits. Please contact us to know more details',
  subtype: 'datasource'
}

Should we separate both errors, timeout (poor connectivity, error with the server) and limits (database/tiler timeout), or keep the same error for both of them?

Also, I've realised, since we're going to have more feedback about the errors, is it still necessary the design with only one button or can we use a generic error + button?

cc @CartoDB/design

[arianaescobar]

IMO, we should separate them. We might want to improve the copy for that limits error and prepare the visual.

Regarding your last question: if we have specific information about the error (like limits or poor connectivity) I would show the full message to properly explain it. But if we don't, I recommend avoiding the repetition of elements. Right now, in the following case, the buttons already feel super repetitive, if we also add a generic message and repeat it all over, it will be too much.

[noguerol]

I totally agree, @CartoDB/design . New ticket for that, please!

[rubenmoya]

I think we already have both tickets, this one for the errors and the other one for the button styles, right?

Btw, right now when there is no data, the widget shows emtpy:

Should I replace that with the "No data available" design? If we move the map to a place without any points/data, we could end up with 5 widgets with the same error message

[arianaescobar]

Yes and yes @rubenmoya

[rjimenezda]

On production 🚢

[xavijam]

:dancer: