CartoDB / kepler.gl

CARTO fork - Kepler.gl is a powerful open source geospatial analysis tool for large-scale data sets.
http://kepler.gl
MIT License
3 stars 3 forks source link

QA environment for 19/02 #44

Closed neokore closed 4 years ago

neokore commented 4 years ago
neokore commented 4 years ago

About the earthquake map issue: I found some slight differences between the original config JSON file and the one we save to CARTO. This changes seems to be applied by Kepler.gl.

Original JSON:

{
  "version": "v1",
  "config": {
    "visState": {
      "filters": [
        {
          "dataId": "earthquakes",
          "id": "vo18yorx",
          "name": "DateTime",
          "type": "timeRange",
          "value": [
            663046722470,
            1301519405470
          ],
          "enlarged": true,
          "plotType": "histogram",
          "yAxis": null
        }
      ],
      "layers": [
        {
          "id": "hty62yd",
          "type": "point",
          "config": {
            "dataId": "earthquakes",
            "label": "Point",
            "color": [
              23,
              184,
              190
            ],
            "columns": {
              "lat": "Latitude",
              "lng": "Longitude",
              "altitude": null
            },
            "isVisible": true,
            "visConfig": {
              "radius": 10,
              "fixedRadius": false,
              "opacity": 0.39,
              "outline": false,
              "thickness": 2,
              "colorRange": {
                "name": "ColorBrewer PRGn-6",
                "type": "diverging",
                "category": "ColorBrewer",
                "colors": [
                  "#762a83",
                  "#af8dc3",
                  "#e7d4e8",
                  "#d9f0d3",
                  "#7fbf7b",
                  "#1b7837"
                ],
                "reversed": false
              },
              "radiusRange": [
                4.2,
                96.2
              ],
              "hi-precision": false
            }
          },
          "visualChannels": {
            "colorField": {
              "name": "Magnitude",
              "type": "real"
            },
            "colorScale": "quantize",
            "sizeField": {
              "name": "Magnitude",
              "type": "real"
            },
            "sizeScale": "sqrt"
          }
        }
      ],
      "interactionConfig": {
        "tooltip": {
          "fieldsToShow": {
            "earthquakes": [
              "DateTime",
              "Latitude",
              "Longitude",
              "Depth",
              "Magnitude"
            ]
          },
          "enabled": true
        },
        "brush": {
          "size": 0.5,
          "enabled": false
        }
      },
      "layerBlending": "normal",
      "splitMaps": []
    },
    "mapState": {
      "bearing": 0,
      "dragRotate": false,
      "latitude": 37.05881309947238,
      "longitude": -122.80009283836715,
      "pitch": 0,
      "zoom": 5.740491857794806,
      "isSplit": false
    },
    "mapStyle": {
      "styleType": "light",
      "topLayerGroups": {},
      "visibleLayerGroups": {
        "border": false,
        "building": true,
        "label": true,
        "land": true,
        "road": true,
        "water": true
      },
      "buildingLayer": {
        "color": [
          237,
          237,
          237
        ],
        "isVisible": false,
        "opacity": 0.7
      }
    }
  }
}

JSON saved:

{
  "version": "v1",
  "config": {
    "visState": {
      "filters": [
        {
          "dataId": [
            "earthquakes"
          ],
          "id": "vo18yorx",
          "name": [
            "DateTime"
          ],
          "type": "timeRange",
          "value": [
            663046722470,
            1301519405470
          ],
          "enlarged": true,
          "plotType": "histogram",
          "yAxis": null
        }
      ],
      "layers": [
        {
          "id": "hty62yd",
          "type": "point",
          "config": {
            "dataId": "earthquakes",
            "label": "Point",
            "color": [
              23,
              184,
              190
            ],
            "columns": {
              "lat": "Latitude",
              "lng": "Longitude",
              "altitude": null
            },
            "isVisible": true,
            "visConfig": {
              "radius": 10,
              "fixedRadius": false,
              "opacity": 0.39,
              "outline": false,
              "thickness": 2,
              "strokeColor": [
                23,
                184,
                190
              ],
              "colorRange": {
                "name": "Uber Viz Diverging 1.5",
                "type": "diverging",
                "category": "Uber",
                "colors": [
                  "#00939C",
                  "#5DBABF",
                  "#BAE1E2",
                  "#F8C0AA",
                  "#DD7755",
                  "#C22E00"
                ]
              },
              "strokeColorRange": {
                "name": "ColorBrewer PRGn-6",
                "type": "diverging",
                "category": "ColorBrewer",
                "colors": [
                  "#762a83",
                  "#af8dc3",
                  "#e7d4e8",
                  "#d9f0d3",
                  "#7fbf7b",
                  "#1b7837"
                ],
                "reversed": false
              },
              "radiusRange": [
                4.2,
                96.2
              ],
              "filled": true
            },
            "textLabel": [
              {
                "field": null,
                "color": [
                  255,
                  255,
                  255
                ],
                "size": 18,
                "offset": [
                  0,
                  0
                ],
                "anchor": "start",
                "alignment": "center"
              }
            ]
          },
          "visualChannels": {
            "colorField": {
              "name": "Magnitude",
              "type": "real"
            },
            "colorScale": "quantize",
            "strokeColorField": null,
            "strokeColorScale": "quantile",
            "sizeField": {
              "name": "Magnitude",
              "type": "real"
            },
            "sizeScale": "sqrt"
          }
        }
      ],
      "interactionConfig": {
        "tooltip": {
          "fieldsToShow": {
            "earthquakes": [
              "DateTime",
              "Latitude",
              "Longitude",
              "Depth",
              "Magnitude"
            ]
          },
          "enabled": true
        },
        "brush": {
          "size": 0.5,
          "enabled": false
        },
        "coordinate": {
          "enabled": false
        }
      },
      "layerBlending": "normal",
      "splitMaps": [],
      "animationConfig": {
        "currentTime": null,
        "speed": 1
      }
    },
    "mapState": {
      "bearing": 0,
      "dragRotate": false,
      "latitude": 37.762665,
      "longitude": -121.28708,
      "pitch": 0,
      "zoom": 6,
      "isSplit": false
    },
    "mapStyle": {
      "styleType": "light",
      "topLayerGroups": {},
      "visibleLayerGroups": {
        "border": false,
        "building": true,
        "label": true,
        "land": true,
        "road": true,
        "water": true
      },
      "threeDBuildingColor": [
        9.665468314072013,
        17.18305478057247,
        31.1442867897876
      ],
      "mapStyles": {}
    }
  }
}

I'm trying to reproduce it with Dropbox, but their provider is broken for private saving.

neokore commented 4 years ago

Finally, I've checked the return for the earthquakes maps using Dropbox and CARTO and they generate the same config json, that differs from the original one, so we can conclude that this bug is produced by Kepler.gl. I recommend communicate it to Uber and maybe check it from our side after finishing all our features.

neokore commented 4 years ago

The QA document by @isapozuelo is here: https://docs.google.com/document/d/1HJpnl_2E9GkY3ExsPJWTxax7BX6d6oo2p32ahhf19oE

ana-md commented 4 years ago

Closing this in favor of this issue