search

CartoDB / kepler.gl

CARTO fork - Kepler.gl is a powerful open source geospatial analysis tool for large-scale data sets.
http://kepler.gl
MIT License
3 stars 3 forks source link

[Bug] URL parameters change to null after loading public map #53

Closed albertoac closed 4 years ago

albertoac commented 4 years ago

Describe the bug When loading a public map such as https://kepler.gl/demo/map/carto?mapId=7ffae2c5-9aa3-99e1-4b5d-e227c268526e&owner=albertoag-carto&privateMap=false the url parameter owner changes to null, which gives problems in case you copy again the url or you just reload the map as the API url tries to access will be https://null.carto.com....

To Reproduce Steps to reproduce the behavior:

  1. Go to https://kepler.gl/demo/map/carto?mapId=7ffae2c5-9aa3-99e1-4b5d-e227c268526e&owner=albertoag-carto&privateMap=false
  2. Wait for the map to load completely (the import modal is closed and you can see the visualization
  3. See the url has changed to https://kepler.gl/demo/map/carto?mapId=7ffae2c5-9aa3-99e1-4b5d-e227c268526e&owner=null&privateMap=false (owner=null)

Expected behavior The url should not change or, if it changes, it should allow the user to see the same content as is visualizing at that moment.

Desktop (please complete the following information):

neokore commented 4 years ago

PR merged, now you can test it at https://kepler.gl/demo

albertoac commented 4 years ago

Seems to be working fine! I close the ticket