search

CartoDB / kepler.gl

CARTO fork - Kepler.gl is a powerful open source geospatial analysis tool for large-scale data sets.
http://kepler.gl
MIT License
3 stars 3 forks source link

[Bug] Normal workflow doesn't allow the user to signup #55

Closed albertoac closed 4 years ago

albertoac commented 4 years ago

Describe the bug While talking with @ana-md , we found that is not possible to signup into carto from kepler using a normal workflow. The problem is that when you click on CARTO, the popup is open in a very small size, similar to a mobile view. In that mobile view there's no signup link, so if the user doesn't have an account it's only solution is to close the modal (or realize that if he makes it bigger it can actually do a signup)

To Reproduce Steps to reproduce the behavior:

  1. Go to https://kepler.gl/demo (in incognito mode preferably, so your account doesn't affect)
  2. Create a new map
  3. Click on save to CARTO
  4. See that the pop up open is 600x600px, so it falls into the mobile view. It will need at least 800px width in order to show the desktop view.

Expected behavior As the signup process is available in mobile view, I think the easiest way to solve is to add the link to the signup in the mobile view so it also appears in the modal.

Screenshots image

Desktop (please complete the following information):

VictorVelarde commented 4 years ago

Fixed!

This is how it looks now image

ana-md commented 4 years ago

Thank you @albertoac and @VictorVelarde !!