Open VictorVelarde opened 5 years ago
There are some mixed references to mapbox v0.50 and v0.52. For example
<script src="https://api.tiles.mapbox.com/mapbox-gl-js/v0.50.0/mapbox-gl.js"></script>
. With CARTO VL 1.1.1, we can use v0.52
The base template could be inside a Vue component, instead of the index itself
Separating a bit more the 'data' / 'computed' / 'methods' (outside of the Vue initialization) could lead to a more clear and easy-to-follow code.
HTML based approach is nice to grab the Vue concepts and small pieces / examples. If we are facing a little more complex project, such as in a PoC, we think that a vue-cli with a main App.vue/js would be preferred.
It's true that introduces new stuff, such as webpack, but the final code would be simpler and it would have a better structure to grow.
- There are some mixed references to mapbox v0.50 and v0.52. For example
<script src="https://api.tiles.mapbox.com/mapbox-gl-js/v0.50.0/mapbox-gl.js"></script>
. With CARTO VL 1.1.1, we can use v0.52
I thought I fixed all, I'll review thanks!!
- The base template could be inside a Vue component, instead of the index itself
You mean that everything inside the #app
div could be put inside a separated component?
- Separating a bit more the 'data' / 'computed' / 'methods' (outside of the Vue initialization) could lead to a more clear and easy-to-follow code.
Can you provide a minimal example? Maybe you can just create a step_10
folder with these two refactoring changes?
Regarding the midterm suggestion, sure, adding more pieces to the set up enables very interesting features but also makes the full approach more complex to deliver to other stakeholders so we need to ensure that we provide an environment with a balance between features and the number of steps to set up the dev environment and the deployment. We'll update this repo as soon as we cross that river :smile:
I'm creating this issue so we can have a place for some conversation about the workshop. Maybe we can add more links to useful resources, comment some tips or patterns... coming from the experiences we've had at @CartoDB/frontend-team