3x VectorLayer deadlock - Githubissues

CartoDB / mobile-sdk

CARTO Mobile SDK core project

https://carto.com/docs/carto-engine/mobile-sdk/

BSD 3-Clause "New" or "Revised" License

186 stars 68 forks source link

3x VectorLayer deadlock #208

Closed Nikituh closed 6 years ago

Nikituh commented 6 years ago

How it happened:

Our current routing sample uses two different layers:

routeLayer for lines and intructions
startStopLayer for start and stop markers.

When implementing transparent route, I had to create to create a routeInstructionLayer in order to keep the instructions full opacity.

How do I know it's to do with VectorLayers?

Unable to reproduce if I comment out one of layer addings:

// mapView.layers.add(routeInstructionLayer)

Steps to reproduce:

Run dev branch of mobile-android-samples: https://github.com/CartoDB/mobile-android-samples/tree/dev
Open offline routing sample and set markers to calculate a route
On that route, zoom in and out
Should freeze after a few seconds

How do I know it's a new issue?

Easily reproducible with local library:

implementation(name:'carto-mobile-sdk-4.1.2.466', ext:'aar')

Cannot reproduce with release version:

implementation 'com.carto:carto-mobile-sdk:4.1.2@aar'

mtehver commented 6 years ago

Good spotting! This is regression in post 4.1.2 code related to layer opacity feature. Fixed now in master branch.