Use obs_meta for OBS_GetMeasureByID, support obs_meta

CartoDB / observatory-extension

BSD 3-Clause "New" or "Revised" License

6 stars 4 forks source link

Use obs_meta for OBS_GetMeasureByID, support obs_meta #136

Closed talos closed 8 years ago

talos commented 8 years ago

Supports use of obs_meta table in our unit tests
- Since this table is too big to save as a fixture, it has to be regenerated -- this is a bit slow, so tests were changed to not drop/create tables between files. That should be safe because we only SELECT in our tests, and we should never alter the fixture data
Use obs_meta table for OBS_GetMeasureByID
- This should result in major performance improvements, saw a factor of ~2.5 on our test setup (which uses FDW)

talos commented 8 years ago

@ohasselblad CR plz

andy-esch commented 8 years ago

This all looks good and straight forward to me.

One minor change I support is having separated-out scripts for creating and dropping the tables instead of having it embedded in the first script which run tests.

talos commented 8 years ago

Yes! I 👍 that idea. Ticket: #139