CartoDB / observatory-extension

BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

OBS_GetMeasure performance improvements #227

Closed rafatower closed 7 years ago

rafatower commented 7 years ago

Just to follow-up on the performance metrics and findings here: https://github.com/CartoDB/dataservices-api/issues/306#issuecomment-264183386

Proposed changes:

Work being done here: https://github.com/CartoDB/observatory-extension/compare/remove-format-literals

Side note: watch out for validity of geometries, especially taking into account these lines (snap to grid and buffers): https://github.com/CartoDB/observatory-extension/blob/cbe7b6dd156554abebce59282e77a62037de0d29/src/pg/sql/41_observatory_augmentation.sql#L372-L382 cc/ @rochoa

talos commented 7 years ago

Additional changes:

talos commented 7 years ago

We're now using OBS_GetData in the UI, and OBS_GetMeasure is doing about as well as it can within the limitations of dynamically choosing geometries each time (if user doesn't choose a geom.)