search

CartoDB / observatory-extension

BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

Make sure NULL does not mess up OBS_GetMeta or OBS_GetData #280

Closed talos closed 7 years ago

talos commented 7 years ago

@mehak-sachdeva and @nygeog have reported issues with Builder Analysis when there is a NULL in the geometry column.

talos commented 7 years ago

@mehak-sachdeva @nygeog was not able to reproduce in Builder. I created maps, one with a point and a NULL geometry, another with a polygon and a NULL geometry. Both augmented just fine, although the NULL geometries were dropped from the output.

Is there some other issue? Could you provide a .carto file?

nygeog commented 7 years ago

@talos I just tested this on my account and the trial I saw this in and everything is fine, both for point and AOI buffers... however, Tract'ed buffers, getting an error. This may have had more to do with "Tracts" and the repeating cartodb_id error than empty geometries.

Data Obs Test 20170403 (on 2017-04-04 at 03.10.55).zip

cc @mehak-sachdeva

nygeog commented 7 years ago

@talos if you want, I could open this elsewhere as I think it more generally effects many analysis rather than just DO. Should I do this?

talos commented 7 years ago

Haven't gotten to look at the test yet (will when I'm in the office) but if there are repeating cartodb_ids somehow then that's going to cause some big problems here and in other analyses too... and needs to be solved elsewhere.

talos commented 7 years ago

This was a more general issue related to duplicate cartodb_ids. Closing.