CartoDB / observatory-extension

BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

Return NULL for the affected value and not for all the measurements #298

Closed ethervoid closed 7 years ago

ethervoid commented 7 years ago

Right now we're doing INNER JOINS when we JOIN the _procgeoms and the data so we end up with NULL value instead of id, NULL value. We need to have the id available to make the JOIN at the end of the query and provide results like this:

id |                               data
----+------------------------------------------------------------------
  1 | [{"value" : 858469},{"value" : 73.9397964478},{"value" : 69092}]
  2 | [{"value" : 738774},{"value" : null},{"value" : 2235406}]

// @juanignaciosl for awareness

ethervoid commented 7 years ago

Executed the tests and everything is OK:

Integration:

----------------------------------------------------------------------
Ran 764 tests in 487.342s

OK (SKIP=24)

Performance:

----------------------------------------------------------------------
Ran 84 tests in 312.151s

OK
ethervoid commented 7 years ago

Acceptance

ethervoid commented 7 years ago

@javitonino should be fixed by now. All tests passes and manual tests worked fine too

javitonino commented 7 years ago

Been doing acceptance with some different examples than suggested, and it works nicely, great job 👏