Automated MS Windows builds

[mlt]

I have rudimentary testing on that platform with MySQL, PG and SQL Server 2017 as it is excessively tested with Travis. I hope this is okay. You'd have to set up AppVeyor account and edit README badge link as well as adjusting GitHub token for binaries to be pushed automatically.

[rafatower]

Hi @mlt, thanks a lot for the PR.

Before proceeding with the changes I have to ask you to read and go through the steps described in https://github.com/CartoDB/odbc_fdw/blob/master/CONTRIBUTING.md#submitting-contributions and get a Contributor License Agreement if you haven't done so yet.

Once that is clear we can go through the changes, polish it a little and eventually merge it. Thanks again for the contribution.

[mlt]

@rafatower I sent an email a few days ago but I didn't hear back. Did it end up in spam folder?

[rafatower]

Thanks, let me check and I'll get back to you. Sorry about the delay.

[agnesgyorfi]

Hi @mlt , thanks for filling out the CLA, and for your contribution. I have checked the spam folder for the associated email and cannot find your message. Would you please re-send to me at a g n e s at c a r t o dot com? thanks!

[mlt]

@agnesgyorfi FYI I forwarded original e-mail few hours ago... nothing bounced back thus far.

[agnesgyorfi]

@rafatower : @mlt signed the CLA last week. Thanks, both!

[manmorjim]

:wave: @mlt. Thank you for contributing and sorry for the delay! We're going to set up the AppVeyor account and merge your changes. We'll keep you up to date about this!

[manmorjim]

We've just created the new branch appveyor-setup with this PR merged in order to test the setup.

[mlt]

It does not look the build was triggered 🤷‍♂ Did you enable AV access to this GH repository❓

[manmorjim]

Did you enable AV access to this GH repository

Not yet. We're working on it :blush:

[manmorjim]

AppVeyor set up succesfuly :green_heart:!

Thank you @mlt :smiley:

[rafatower]

You'd have to set up AppVeyor account and edit README badge link as well as adjusting GitHub token for binaries to be pushed automatically.

@manmorjim just double-checking: are we using our AppVeyor or mit's in master? the badge link seems to point to a non-carto project.

[manmorjim]

@manmorjim just double-checking: are we using our AppVeyor or mit's in master? the badge link seems to point to a non-carto project.

@rafatower This PR fixes that.

[mlt]

Heh... I guess I was too slow to reply 😇 One more thing. You'll need to generate GH token and encrypt it with AV to use instead of mine to be able to push build artifacts (ZIPs) to GH Releases upon git tagging automatically.

Relevants docs: https://www.appveyor.com/docs/deployment/github/

[manmorjim]

You'll need to generate GH token and encrypt it with AV to use instead of mine to be able to push build artifacts (ZIPs) to GH Releases upon git tagging automatically.

done!

[taywater]

Please forgive my ignorance, but will this result in Windows binaries that are available to download, or just ensure that compilation on Windows is possible?

[manmorjim]

will this result in Windows binaries that are available to download, or just ensure that compilation on Windows is possible?

@taywater I'm afraid that this only ensures you can compile on Windows. Windows binaries are not generated ATM :sweat_smile:.

[taywater]

That's fair. Thanks for the information!

[mlt]

@taywater If you are in a pinch, you can try AppVeyor generated binaries (artifacts) from my repo. They are just a few commits behind.

[taywater]

@taywater If you are in a pinch, you can try AppVeyor generated binaries (artifacts) from my repo. They are just a few commits behind.

I'm having trouble with the most recent artifact from here https://ci.appveyor.com/project/alberhander/odbc-fdw/builds/30857327/job/ilhkcd19beyf4bgo/artifacts

It's installed correctly, but I'm getting a 58000 SQL error connecting to the driver. The artifacts from the 0.5.0 release have been deleted for being too old on AppVeyor (older than 6 months). Any chance those binaries are still available someplace?

[mlt]

Did it work before? Are you using DSN or naming everything manually?

Also... I think after PG12 got released they still use VCRUNTIME140.dll whereas platform toolset v141 is used on AppVeyor. I'll submit a PR. But this should affect only those not having such VC runtime installed in the system. 58000 SQL error likely means something else.

Edit: Here is the one with v140 for PG 12

[taywater]

Did it work before? Are you using DSN or naming everything manually?

Also... I think after PG12 got released they still use VCRUNTIME140.dll whereas platform toolset v141 is used on AppVeyor. I'll submit a PR. But this should affect only those not having such VC runtime installed in the system. 58000 SQL error likely means something else.

Edit: Here is the one with v140 for PG 12

Hi there. It definitely worked before. The connections are set up with a system DSN that is fully functional when connected to in other ODBC-aware applications. I've copied over a definition for a foreign table from our Postgres 9.6 database, that uses the extension binary located here: http://www.postgresonline.com/journal/archives/372-ODBC-FDW-now-supports-9.5-and-9.6.html. That connection works in the 9.6 DB just fine.

I've replaced the files from the 14.1 version with the 14.0 version, but the error is the same. SQL State 58000, with "Error executing ODBC query" as the message. I wish I had more info to share! This is a stock installation of Postgres 12.0 on Windows Server 2012.