search

CartoDB / odbc_fdw

PostgreSQL Foreign-data Wrapper for ODBC
Other
70 stars 22 forks source link

PG12 compatibility #104

Closed Algunenano closed 5 years ago

Algunenano commented 5 years ago

Untested. Needs CI fixed first and then integrate PG12 in Travis. Fixes https://github.com/CartoDB/odbc_fdw/issues/103

mlt commented 5 years ago

It could be shorter https://github.com/CartoDB/odbc_fdw/commit/b08830b072b425871d858e3f4e52d1d80355da8e . I can use yours instead and test on Windows with AppVeyor CI.

Algunenano commented 5 years ago

The problem with keeping heap_open is that it is highly likely to disappear in PG13, so I'd rather fix it once and for all. In any case, now that I look at it again I don't like having multiple #ifdefs in the code itself so I think I'll move it into a macro in the top of the file. I'll certainly revisit this once the CI is working again.