search

CartoDB / odbc_fdw

PostgreSQL Foreign-data Wrapper for ODBC
Other
66 stars 22 forks source link

Fix potential privacy problem. #128

Closed jgoizueta closed 3 years ago

jgoizueta commented 3 years ago

The CREATE FOREIGN TABLE statements generated by IMPORT FOREIGN SCHEMA contain all the OPTIONS defined in the corresponding SERVER and USER MAPPING.

This is a potencial privacy problem, since USER MAPPING options can be confidential (passwords, ...) and when they are inserted in an statement to be executed the could be revealed through error (or debug) messages.

jgoizueta commented 3 years ago

I see the tests for 9.5, 9.6 failed because ‘DefElem {aka struct DefElem}’ has no member named ‘location’. I guess that field was introduced in PG 10 🤦

Well, maybe I'l do the options filtering only for PG>=10, which is the use case we're interested on.

Algunenano commented 3 years ago

I see the tests for 9.5, 9.6 failed because ‘DefElem {aka struct DefElem}’ has no member named ‘location’. I guess that field was introduced in PG 10 facepalm

Maybe it's a good time to drop 9.5 and 9.6 (and clean related code). We don't use them any more.

jgoizueta commented 3 years ago

Yeah, I think it's time to drop 9.X: https://app.clubhouse.io/cartoteam/story/113666/drop-support-for-pg-10-in-odbc-fdw