search

CartoDB / odyssey.js

Making it easy to merge map and narrative
BSD 3-Clause "New" or "Revised" License
1.62k stars 187 forks source link

Support vizjson on all templates #151

Closed andrewxhill closed 10 years ago

andrewxhill commented 10 years ago

For not just torque Not only a single layer

Why we didn't do this from the beginning?

andrewxhill commented 10 years ago

in fact, it should likely be supported at the each chapter with the ability to remove old ones.... i know this is advanced control. but imagine Pluto Data Tour

matallo commented 10 years ago

Yeah, I'm working in some kind of filtering with layers from vizjson, @javisantana and @saleiva explained the behavior to me but there isn't an open ticket about it (ouch!)

Feel free to write some lines explaining what would you expect from that. On Jun 17, 2014 11:21 PM, "Andrew W. Hill" notifications@github.com wrote:

in fact, it should likely be supported at the each chapter with the ability to remove old ones.... i know this is advanced control. but imagine Pluto Data Tour

— Reply to this email directly or view it on GitHub https://github.com/CartoDB/odyssey.js/issues/151#issuecomment-46367055.

andrewxhill commented 10 years ago

Well, I think we should just load vizjson with something very close to a raw cartodb.createVis

If we detect layertype = 'torque' we can also allow torque type actions in the slides for that layer, right?

matallo commented 10 years ago

I added vizjson support and filtering (see https://github.com/CartoDB/odyssey.js/issues/152) but is per template basis, not per slides

if it still required (which I think it is) we should have some discussion as @javisantana already told me there can be a better approach, right now we're just throwing features to the library

javisantana commented 10 years ago

Why we didn't do this from the beginning?

we didn't because oddyseey shouldn't be attached to cartodb, at least at the beginning it was like that. I feel like supporting vizjson is too much and we should wait until this is integrated with cartodb

andrewxhill commented 10 years ago

yep, i agree why we didn't do it from the beginning. but makes a lot of sense to allow a vizjson url with no further modifications to it.

same might be in the nice to support

On Wed, Jun 18, 2014 at 6:44 AM, javi santana notifications@github.com wrote:

Why we didn't do this from the beginning?

we didn't because oddyseey shouldn't be attached to cartodb, at least at the beginning it was like that. I feel like supporting vizjson is too much and we should wait until this is integrated with cartodb

— Reply to this email directly or view it on GitHub https://github.com/CartoDB/odyssey.js/issues/151#issuecomment-46420248.

andrew@vizzuality.com http://www.vizzuality.com

matallo commented 10 years ago

I'm closing this as we already have vizjson support in all templates. We should collect all the suggestions somewhere, though.