search

CartoDB / odyssey.js

Making it easy to merge map and narrative
BSD 3-Clause "New" or "Revised" License
1.62k stars 188 forks source link

Torque template: repeating overwrites first slide #166

Closed peterdesmet closed 10 years ago

peterdesmet commented 10 years ago

I tried to create a Odyssey story with the Torque template and stumbled upon a number of issues. The main one, which is also present in the template is as follows:

  1. Animation plays fine, showing different slides in order
  2. After last slide, Torque animation repeats
  3. Instead of showing the first slide again (step: 0), the last slide remains
  4. Only when the step is reached for the second slide, the last slide disappears, now showing the second slide.
  5. So, for an animation with 4 slides we get: 1 2 3 4 2 3 4 2 3 4 etc.
matallo commented 10 years ago

Hey peter,

it's a similar approach than scroll template but trying to be clever about the front slide went bad in this case.

so I reverted the front slide and just added a default -step 0 slide, feel free to check the PR and I'll merge https://github.com/CartoDB/odyssey.js/pull/169

peterdesmet commented 10 years ago

Hi Carlos,

Tried it locally in the editor and it works. Would merge. Thanks!

PS: Will this change update existing Odyssey Torque examples?

matallo commented 10 years ago

it won't as it's in the html and those are exported in the bl.ocks, the regression changes are those in the library itself

definitely, I already mentioned we would need to start thinking about versioning