search

CartoDB / pg_schema_triggers

PostgreSQL 9.3+ Schema Triggers extension
BSD 2-Clause "Simplified" License
11 stars 6 forks source link

SnapshotNow was removed #2

Closed ghost closed 9 years ago

ghost commented 9 years ago

SnapshotNow was removed from the Postgres codebase in August 2013. http://www.postgresql.org/message-id/E1V4uGr-0006GY-DR@gemulon.postgresql.org

This stops pg_schema_triggers (and CartoDB) being used with anything over 9.3.6 (barring other maintenance releases in the 9.3.x series)

Is there a plan to upgrade the extension?

javisantana commented 9 years ago

I think the short term plan is to remove the dependency with this extension, we are not using it.

cc @pramsey

pramsey commented 9 years ago

Remove the dependency on SnapshotNow from the extension, or remove the dependency on the extension from CartoDB?

javisantana commented 9 years ago

remove the dependency on the extension from CartoDB

that's it, we are not actually using it

pramsey commented 9 years ago

Given the future utility (allowing DDL by users without breaking cartodb), should I consider fixing the extension?

javisantana commented 9 years ago

yep, fixing the extension would be good but removing it for the moment would solve lot of problems. I don't know if postgres is planning to support this builtin.

Could you take a look?

pramsey commented 9 years ago

There's no real enhancement to event triggers in 9.4, so we'll need the extension there for sure. 9.5 may have some improvements, have to look more closely into it.

ghost commented 9 years ago

Some more background - I'm currently trying to build & run CartoDB on Windows. Less extensions to build would be a good thing - should I skip this one?

javisantana commented 9 years ago

@voltagex you can skip this extension for sure.

You are brave :)

pramsey commented 9 years ago

The current master should be supported by 9.4 and I see no changes in 9.3 that remove SnapshotNow