Disable conditional allow overlap

IagoLast commented 7 years ago

[#58] As discussed in #55 and documented in the docs once this PR is merged an error will be thrown if conditional marker-allow-overlap is found.

Aceptance criteria

[x] Load some css where the marker-allow-overlap is not conditional and check there is no errors.
[x] Load some css where the marker-allow-overlap is conditional and check an error is thrown.

IagoLast commented 7 years ago

Regarding to the zoom issue.

The zoom is not in the filters array (we have this.filters and this.zoom).

Carto generates the js rules adding a "zoom" filter by default so when there are no filters the rules are like this:

if(zoom < infinity) {  // Always true
  _value = 'foo';
}

This was making the filtered value to always return true.

I changed that and I removed a bug to create a new one!

I guess I have to change the CARTO code again, to consider the zoom for the filtered field only when the zoom is smaller than the maximun value.

alonsogarciapablo commented 7 years ago

I guess I have to change the CARTO code again, to consider the zoom for the filtered field only when the zoom is smaller than the maximum value.