search

CartoDB / tangram-cartocss

⛔️ DEPRECATED Transform cartocss into a draw tangram object
https://cartodb.github.io/tangram-cartocss/
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

Fix marker blending #65

Closed IagoLast closed 7 years ago

IagoLast commented 7 years ago

Following https://github.com/CartoDB/tangram-reference/issues/7

The getBlending function for markers needs to translate the mapnik/cartocss values into tangram ones according to the following table:

Mapnik name Tangram name
src-over overlay
multiply multiply*
plus add

(*) Tangram doesnt support multiply among many other omited blend modes yet!

This PR fixes this function returning the translated value.

Also, the getBlending function will now return the default value from the reference and will throw an error when the comp-op is being filtered.

alonsogarciapablo commented 7 years ago

It looks like there's some conflict with the work that @dv343 and @rochoa are doing in https://github.com/CartoDB/tangram-carto/pull/64.

rochoa commented 7 years ago

This is superseded by #69.