search

CartoDB / toolkit

JS library to interact with CARTO APIs in a simple way
https://toolkit-wheat.now.sh
BSD 3-Clause "New" or "Revised" License
9 stars 3 forks source link

Update deckgl to 8.1.5 version #109

Closed manmorjim closed 4 years ago

manmorjim commented 4 years ago

The version 8.1.5 fixes the clipping issue

image

manmorjim commented 4 years ago

The build was failing due to the typescript version 3.9.2 has a bug https://github.com/microsoft/TypeScript/issues/38535

I've fixed the version 3.8.3 which is prior to 3.9.2.

manmorjim commented 4 years ago

TS version updated and pinned for all packages.

I've also updated all examples to use deckgl 8.1.5

VictorVelarde commented 4 years ago

@manmorjim Hey, I was also checking / updating the examples and we need to update ALL deck.gl components to 8.1.5 in package.json files (luma, geo-layers, etc) because otherwise the examples will fail

manmorjim commented 4 years ago

@manmorjim Hey, I was also checking / updating the examples and we need to update ALL deck.gl components to 8.1.5 in package.json files (luma, geo-layers, etc) because otherwise the examples will fail

All deckgl components were updated to 8.1.5 except lumaGL due to deckgl 8.1.5 uses lumaGL version 8.1.2.

VictorVelarde commented 4 years ago

Don't merge this please, I would mix this with my PR on examples

VictorVelarde commented 4 years ago

Done in https://github.com/CartoDB/toolkit/pull/110