Style helpers improvements

[simon-contreras-deel]

Plan

By helper and geometry type review:

• Size
• Stroke width
• Stroke color
• Default palette
• size continuous linear extrapolation
• color helpers with lines
• updateTriggers review
• debug examples
• deck.gl examples

[vercel[bot]]

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carto-frontend/toolkit/fpc6ebdb5 ✅ Preview: https://toolkit-git-helpers-use-size-in-pixels.carto-frontend.now.sh

[VictorVelarde]

Acceptance checklist

• [x] basic
  • [x] size
  • [x] color
  • [x] strokeWidth
  • [x] strokeColor
  • [x] opacity
  • [x] default styles (no params)
• [x] colorBins (missing line example)
  • [x] size
  • [x] strokeWidth
  • [x] strokeColor
  • [x] opacity
  • [x] default palette
• [ ] colorCategories (missing line / points examples)
  • [ ] size
  • [ ] strokeWidth
  • [x] strokeColor
  • [x] opacity
  • [x] default palette
• [ ] colorContinuous (missing lines example)
  • [x] size
  • [x] strokeWidth
  • [x] strokeColor
  • [x] default palette
• [ ] sizeBins
  • [x] color
  • [x] strokeWidth
  • [x] strokeColor
  • Size 'jumps' on zoom changes, and sometimes it doesn't trigger a redraw and size looks wrong.
• [ ] sizeCategories
  • [x] color
  • [x] strokeWidth
  • [x] strokeColor
  • [x] default range
  • Size 'jumps' on zoom changes, and sometimes it doesn't trigger a redraw and size looks wrong.
• [ ] sizeContinuous
  • [x] color
  • [x] strokeWidth
  • [x] strokeColor
  • Size jumps / wrong size

[VictorVelarde]

Nice work on this. Debug examples you have prepared are being really useful for validation.

I made a first review of all the debug examples, and everything looks fine except the size helpers. I still see 'jumps' and wrong pixel sizes (sizeBins, sizeCategories and sizeContinuous). Logic for adjusting based on viewport is not yet working fine

The rest of tests I made look fine: default palettes, override style options...

[simon-contreras-deel]

I still see 'jumps'

In the basic helper, as all the points have the same size, I changed it to use pointRadiusMinPixels and pointRadiusMaxPixels with the same value: the expected point size. That way, size does not change over zoom (it can not change)

I tried to follow a smilar idea with this cases, but it is not possible. All the stuff we can to to force size, it does not depends on features, but are general to the layer. The only way I can see is to change deck.gl to support pixels width in points.

wrong pixel sizes

I am checking it.

[VictorVelarde]

As we said, let's focus on wrong side (a-must), and forget a bit about 'jumps' (nice-to-have).

[simon-contreras-deel]

After playing with the @jesusbotella deck example, I see the pointRadiusScale does not affect to pointRadiusMinPixels and pointRadiusMinPixels. So:

• we should not use together or
• we should apply the pointRadiusScale to pointRadiusMinPixels and pointRadiusMinPixels

I a going to follow the second one if possible.

[alasarr]

Needs to fix conflicts after merge interactivity