Closed simon-contreras-deel closed 4 years ago
vercel[bot]
commented
4 years ago This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/carto-frontend/toolkit/13cnis0yo ✅ Preview: https://toolkit-git-style-helper-validations.carto-frontend.now.sh
VictorVelarde
commented
4 years ago 🔝 commit removes custom buffer (previously mvt: 30) for both size-categories and size-bins helpers examples. I was not able to see any glitch removing them, and I think examples should be simple. We might add a custom map instantiation example in the future though, passing extra parameters... but I think that's not required yet
I think these examples were created by @manmorjim . Manu can you spot any style issue on them?
manmorjim
commented
4 years ago :top commit removes custom buffer (previously mvt: 30) for both size-categories and size-bins helpers examples. I was not able to see any glitch removing them, and I think examples should be simple. We might add a custom map instantiation example in the future though, passing extra parameters... but I think that's not required yet
I think these examples were created by @manmorjim . Manu can you spot any style issue on them?
They both look great. I think the MVT buffer is not needed since the issue about clipping was fixed.
BTW I experimented a very uncommon issue about weird lines in the size-categories-style.html example. In some zoom levels some 'nonexistent' lines appear:
I think this is a deckgl issue rather than web-sdk.
VictorVelarde
commented
4 years ago Thx @manmorjim. The artifacts might be related to https://github.com/visgl/deck.gl/issues/4604, but we should consider it outside of this PR
simon-contreras-deel
commented
4 years ago Added upper limits for bins and top categories in related helpers
https://app.clubhouse.io/cartoteam/story/76421/validations-of-style-helper-params